| Message ID | 20180424084408.28034-1-sedat.dilek@credativ.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2018-04-24 17:44 GMT+09:00 Sedat Dilek <sedat.dilek@credativ.de>: > Signed-off-by: Sedat Dilek <sedat.dilek@credativ.de> > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 83b6c541565a..e1869dc08288 100644 > --- a/Makefile > +++ b/Makefile > @@ -366,7 +366,7 @@ HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ > -fomit-frame-pointer -std=gnu89 $(HOST_LFS_CFLAGS) > HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) > HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) > -HOST_LOADLIBES := $(HOST_LFS_LIBS) > +HOST_LOADLIBS := $(HOST_LFS_LIBS) > > # Make variables (CC, etc...) > AS = $(CROSS_COMPILE)as > @@ -433,7 +433,7 @@ LDFLAGS := > GCC_PLUGINS_CFLAGS := > > export ARCH SRCARCH CONFIG_SHELL HOSTCC HOSTCFLAGS CROSS_COMPILE AS LD CC > -export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBES > +export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBS > export MAKE LEX YACC AWK GENKSYMS INSTALLKERNEL PERL PYTHON PYTHON2 PYTHON3 UTS_MACHINE > export HOSTCXX HOSTCXXFLAGS LDFLAGS_MODULE CHECK CHECKFLAGS > Why is this a typo? Our Makefiles use HOST_LOADLIBES consistently. $ git grep HOST_LOADLIB Makefile:HOST_LOADLIBES := $(HOST_LFS_LIBS) Makefile:export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBES scripts/Makefile.host: $(HOST_LOADLIBES) $(HOSTLOADLIBES_$(@F)) scripts/Makefile.host: $(HOST_LOADLIBES) $(HOSTLOADLIBES_$(@F)) scripts/Makefile.host: $(HOST_LOADLIBES) $(HOSTLOADLIBES_$(@F)) scripts/Makefile.host: $(HOST_LOADLIBES) $(HOSTLOADLIBES_$(@F)) scripts/Makefile.host: $(HOST_LOADLIBES) $(HOSTLOADLIBES_$(@F))
> Masahiro Yamada <yamada.masahiro@socionext.com> hat am 24. April 2018 um 17:51 geschrieben: > > > 2018-04-24 17:44 GMT+09:00 Sedat Dilek <sedat.dilek@credativ.de>: > > Signed-off-by: Sedat Dilek <sedat.dilek@credativ.de> > > --- > > Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 83b6c541565a..e1869dc08288 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -366,7 +366,7 @@ HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ > > -fomit-frame-pointer -std=gnu89 $(HOST_LFS_CFLAGS) > > HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) > > HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) > > -HOST_LOADLIBES := $(HOST_LFS_LIBS) > > +HOST_LOADLIBS := $(HOST_LFS_LIBS) > > > > # Make variables (CC, etc...) > > AS = $(CROSS_COMPILE)as > > @@ -433,7 +433,7 @@ LDFLAGS := > > GCC_PLUGINS_CFLAGS := > > > > export ARCH SRCARCH CONFIG_SHELL HOSTCC HOSTCFLAGS CROSS_COMPILE AS LD CC > > -export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBES > > +export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBS > > export MAKE LEX YACC AWK GENKSYMS INSTALLKERNEL PERL PYTHON PYTHON2 PYTHON3 UTS_MACHINE > > export HOSTCXX HOSTCXXFLAGS LDFLAGS_MODULE CHECK CHECKFLAGS > > > > Why is this a typo? > > > Our Makefiles use HOST_LOADLIBES consistently. > OK. Do you happen to know why it is LOADLIB*E*S? - Sedat - > > $ git grep HOST_LOADLIB > Makefile:HOST_LOADLIBES := $(HOST_LFS_LIBS) > Makefile:export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBES > scripts/Makefile.host: $(HOST_LOADLIBES) $(HOSTLOADLIBES_$(@F)) > scripts/Makefile.host: $(HOST_LOADLIBES) > $(HOSTLOADLIBES_$(@F)) > scripts/Makefile.host: $(HOST_LOADLIBES) > $(HOSTLOADLIBES_$(@F)) > scripts/Makefile.host: $(HOST_LOADLIBES) > $(HOSTLOADLIBES_$(@F)) > scripts/Makefile.host: $(HOST_LOADLIBES) > $(HOSTLOADLIBES_$(@F)) > > > > > -- > Best Regards > Masahiro Yamada
2018-04-25 0:59 GMT+09:00 Sedat Dilek <sedat.dilek@credativ.de>: >> Masahiro Yamada <yamada.masahiro@socionext.com> hat am 24. April 2018 um 17:51 geschrieben: >> >> >> 2018-04-24 17:44 GMT+09:00 Sedat Dilek <sedat.dilek@credativ.de>: >> > Signed-off-by: Sedat Dilek <sedat.dilek@credativ.de> >> > --- >> > Makefile | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/Makefile b/Makefile >> > index 83b6c541565a..e1869dc08288 100644 >> > --- a/Makefile >> > +++ b/Makefile >> > @@ -366,7 +366,7 @@ HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ >> > -fomit-frame-pointer -std=gnu89 $(HOST_LFS_CFLAGS) >> > HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) >> > HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) >> > -HOST_LOADLIBES := $(HOST_LFS_LIBS) >> > +HOST_LOADLIBS := $(HOST_LFS_LIBS) >> > >> > # Make variables (CC, etc...) >> > AS = $(CROSS_COMPILE)as >> > @@ -433,7 +433,7 @@ LDFLAGS := >> > GCC_PLUGINS_CFLAGS := >> > >> > export ARCH SRCARCH CONFIG_SHELL HOSTCC HOSTCFLAGS CROSS_COMPILE AS LD CC >> > -export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBES >> > +export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBS >> > export MAKE LEX YACC AWK GENKSYMS INSTALLKERNEL PERL PYTHON PYTHON2 PYTHON3 UTS_MACHINE >> > export HOSTCXX HOSTCXXFLAGS LDFLAGS_MODULE CHECK CHECKFLAGS >> > >> >> Why is this a typo? >> >> >> Our Makefiles use HOST_LOADLIBES consistently. >> > > OK. Do you happen to know why it is LOADLIB*E*S? I do not know. Historical convention. LOADLIBES and/or LDLIBS is conventionally used. You will see them by running 'make --print-data-base' > - Sedat - > >> >> $ git grep HOST_LOADLIB >> Makefile:HOST_LOADLIBES := $(HOST_LFS_LIBS) >> Makefile:export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBES >> scripts/Makefile.host: $(HOST_LOADLIBES) $(HOSTLOADLIBES_$(@F)) >> scripts/Makefile.host: $(HOST_LOADLIBES) >> $(HOSTLOADLIBES_$(@F)) >> scripts/Makefile.host: $(HOST_LOADLIBES) >> $(HOSTLOADLIBES_$(@F)) >> scripts/Makefile.host: $(HOST_LOADLIBES) >> $(HOSTLOADLIBES_$(@F)) >> scripts/Makefile.host: $(HOST_LOADLIBES) >> $(HOSTLOADLIBES_$(@F)) >> >> >> >> >> -- >> Best Regards >> Masahiro Yamada > > -- > Mit freundlichen Grüssen, > Sedat Dilek > > Telefon: +49 2166 9901-153 > E-Mail: sedat.dilek@credativ.de > Internet: https://www.credativ.de/ > > GPG-Fingerprint: EA6D E17D D269 AC7E 101D C910 476F 2B3B 0AF7 F86B > > credativ GmbH, Trompeterallee 108, 41189 Mönchengladbach > Handelsregister: Amtsgericht Mönchengladbach, HR-Nummer: HRB 12080, UID-Nummer: DE204566209 > Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer > > ********************************************** > Jetzt neu: > Elephant Shed - PostgreSQL Appliance > PostgreSQL und alles was dazugehört > > Von Backup über Monitoring bis Reporting: > https://elephant-shed.io/ > ********************************************** > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Makefile b/Makefile index 83b6c541565a..e1869dc08288 100644 --- a/Makefile +++ b/Makefile @@ -366,7 +366,7 @@ HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ -fomit-frame-pointer -std=gnu89 $(HOST_LFS_CFLAGS) HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) -HOST_LOADLIBES := $(HOST_LFS_LIBS) +HOST_LOADLIBS := $(HOST_LFS_LIBS) # Make variables (CC, etc...) AS = $(CROSS_COMPILE)as @@ -433,7 +433,7 @@ LDFLAGS := GCC_PLUGINS_CFLAGS := export ARCH SRCARCH CONFIG_SHELL HOSTCC HOSTCFLAGS CROSS_COMPILE AS LD CC -export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBES +export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBS export MAKE LEX YACC AWK GENKSYMS INSTALLKERNEL PERL PYTHON PYTHON2 PYTHON3 UTS_MACHINE export HOSTCXX HOSTCXXFLAGS LDFLAGS_MODULE CHECK CHECKFLAGS
Signed-off-by: Sedat Dilek <sedat.dilek@credativ.de> --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)