diff mbox

kbuild: gcov: enable -fno-tree-loop-im if supported

Message ID 20180426212807.196279-1-ndesaulniers@google.com (mailing list archive)
State New, archived
Headers show

Commit Message

Nick Desaulniers April 26, 2018, 9:28 p.m. UTC
Clang does not recognize this compiler option.

Reported-by: Prasad Sodagudi <psodagud@quicinc.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
 Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Nick Desaulniers April 26, 2018, 9:41 p.m. UTC | #1
Hi Masahiro and Michal,

The reporter has asked for their email address to be updated to:

psodagud@codeaurora.org

if you're ok with this version of the patch and choose to apply it, can you
please update the commit message. Otherwise, I'll make this change should
we need other changes necessitating a v2.
On Thu, Apr 26, 2018 at 2:29 PM Nick Desaulniers <ndesaulniers@google.com>
wrote:

> Clang does not recognize this compiler option.

> Reported-by: Prasad Sodagudi <psodagud@quicinc.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
>   Makefile | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)

> diff --git a/Makefile b/Makefile
> index 83b6c541565a..7f653c924c18 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -623,7 +623,9 @@ all: vmlinux

>   KBUILD_CFLAGS  += $(call cc-option,-fno-PIE)
>   KBUILD_AFLAGS  += $(call cc-option,-fno-PIE)
> -CFLAGS_GCOV    := -fprofile-arcs -ftest-coverage -fno-tree-loop-im
$(call cc-disable-warning,maybe-uninitialized,)
> +CFLAGS_GCOV    := -fprofile-arcs -ftest-coverage \
> +       $(call cc-option,-fno-tree-loop-im) \
> +       $(call cc-disable-warning,maybe-uninitialized,)
>   export CFLAGS_GCOV CFLAGS_KCOV

>   # The arch Makefile can set ARCH_{CPP,A,C}FLAGS to override the default
> --
> 2.17.0.441.gb46fe60e1d-goog



--
Thanks,
~Nick Desaulniers
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Masahiro Yamada May 5, 2018, 10:35 a.m. UTC | #2
2018-04-27 6:41 GMT+09:00 Nick Desaulniers <ndesaulniers@google.com>:
> Hi Masahiro and Michal,
>
> The reporter has asked for their email address to be updated to:
>
> psodagud@codeaurora.org
>
> if you're ok with this version of the patch and choose to apply it, can you
> please update the commit message. Otherwise, I'll make this change should
> we need other changes necessitating a v2.
> On Thu, Apr 26, 2018 at 2:29 PM Nick Desaulniers <ndesaulniers@google.com>
> wrote:
>
>> Clang does not recognize this compiler option.
>
>> Reported-by: Prasad Sodagudi <psodagud@quicinc.com>
>> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Applied to linux-kbuild
with the reporter's email address updated.

Thanks!
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 83b6c541565a..7f653c924c18 100644
--- a/Makefile
+++ b/Makefile
@@ -623,7 +623,9 @@  all: vmlinux
 
 KBUILD_CFLAGS	+= $(call cc-option,-fno-PIE)
 KBUILD_AFLAGS	+= $(call cc-option,-fno-PIE)
-CFLAGS_GCOV	:= -fprofile-arcs -ftest-coverage -fno-tree-loop-im $(call cc-disable-warning,maybe-uninitialized,)
+CFLAGS_GCOV	:= -fprofile-arcs -ftest-coverage \
+	$(call cc-option,-fno-tree-loop-im) \
+	$(call cc-disable-warning,maybe-uninitialized,)
 export CFLAGS_GCOV CFLAGS_KCOV
 
 # The arch Makefile can set ARCH_{CPP,A,C}FLAGS to override the default