From patchwork Fri Mar 15 16:25:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10855179 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 00DE11515 for ; Fri, 15 Mar 2019 16:25:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF2CE2A9D7 for ; Fri, 15 Mar 2019 16:25:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D30F22AB38; Fri, 15 Mar 2019 16:25:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 800E12A9D7 for ; Fri, 15 Mar 2019 16:25:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729482AbfCOQZd (ORCPT ); Fri, 15 Mar 2019 12:25:33 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:46092 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729454AbfCOQZd (ORCPT ); Fri, 15 Mar 2019 12:25:33 -0400 Received: by mail-pg1-f196.google.com with SMTP id a22so6781135pgg.13 for ; Fri, 15 Mar 2019 09:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rN3A7buDQlB9c4mtpZDNlco/0biGjElcizq2wWkAk70=; b=RrInFBRc3LDUi0w3VL3MZVhUEhaTvJ3THS8BvO5nKS/q2gPmF7HF1ISslwSKQ8eDsp bFf64XMTTNS3IJfc2NKa4LwvCysVdfiUx0RlskZs03nhvfMTq3zqG7EEJih0SlytSq9N fcfdS3lAezv6py/k0AXgu3EbZhTxChSEPwAvs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rN3A7buDQlB9c4mtpZDNlco/0biGjElcizq2wWkAk70=; b=ZjuxsrBXT4uTgH9mBJKtYjiVljA+1q5jh391ZikX5qelhtiy036oEPXMwRfhlOmYct m6ISbFbTq0/Wg9Gxnpc/vJhWv9mo0m/xXZnmh/lk70dAES6VtHK2U12hK6VU4vC7jdYd TEK4JcopYFBjSaoUp+Z6wzd4FcgBqGUybhVFsbnUHhiSvOG2nGUtPn8fdynKiWz6TFRI nGCkV7p3n+Dl/es4wDE65uf5zZFyWFftcjH2lee4L/bc1s4C7myJ1mQcIOJ6IYY9UVGr 3sJpYl43+8dVzTn6Fybl5I25I7EWB31JKRJXQ+0dOrZfEgR1IDwuywPCd1udCpPXXoKL xMkQ== X-Gm-Message-State: APjAAAWo/7j23HdjMr/HXKPj1QfR8IOvAbUsar/lGNZ8qcC+DqQKeE2m q80/j1wyyUOb+seYrShOxcxCdg== X-Google-Smtp-Source: APXvYqz7sCiD7RhJ/hNAHL75l3C1ucOJ6Z65qYTLJVabRSJgMGfuUWEz5aDAbiHi2mWX8PJrTLUoXw== X-Received: by 2002:a63:d209:: with SMTP id a9mr4218554pgg.341.1552667132413; Fri, 15 Mar 2019 09:25:32 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id 138sm1664080pfx.93.2019.03.15.09.25.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2019 09:25:31 -0700 (PDT) From: Douglas Anderson To: Masahiro Yamada Cc: David Howells , David Woodhouse , Douglas Anderson , Michal Marek , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: [PATCH] Revert "modsign: Abort modules_install when signing fails" Date: Fri, 15 Mar 2019 09:25:03 -0700 Message-Id: <20190315162503.131510-1-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.360.g471c308f928-goog MIME-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit caf6fe91ddf62a96401e21e9b7a07227440f4185. The commit was fine but is no longer needed as of commit 3a2429e1faf4 ("kbuild: change if_changed_rule for multi-line recipe"). Let's go back to using ";" to be consistent. For some discussion, see: https://lkml.kernel.org/r/CAK7LNASde0Q9S5GKeQiWhArfER4S4wL1=R_FW8q0++_X3T5=hQ@mail.gmail.com Signed-off-by: Douglas Anderson --- scripts/Makefile.modinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index ff5ca9817a85..0dae402661f3 100644 --- a/scripts/Makefile.modinst +++ b/scripts/Makefile.modinst @@ -23,7 +23,7 @@ quiet_cmd_modules_install = INSTALL $@ mkdir -p $(2) ; \ cp $@ $(2) ; \ $(mod_strip_cmd) $(2)/$(notdir $@) ; \ - $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) && \ + $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) ; \ $(mod_compress_cmd) $(2)/$(notdir $@) # Modules built outside the kernel source tree go into extra by default