| Message ID | 20190627191448.110756-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kbuild: Add ability to test Clang's integrated assembler | expand |
On Thu, Jun 27, 2019 at 12:15 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > > There are some people interested in experimenting with Clang's > integrated assembler. To make it easy to do so without source > modification, allow the user to specify 'AS=clang' as part of the > make command to avoid adding '-no-integrated-as' to the {A,C}FLAGS. > > Link: https://github.com/ClangBuiltLinux/linux/issues/577 > Suggested-by: Dmitry Golovin <dima@golovin.in> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index 5102b2bbd224..d77481129339 100644 > --- a/Makefile > +++ b/Makefile > @@ -527,7 +527,9 @@ endif > ifneq ($(GCC_TOOLCHAIN),) > CLANG_FLAGS += --gcc-toolchain=$(GCC_TOOLCHAIN) > endif > +ifeq ($(shell $(AS) --version 2>&1 | head -n 1 | grep clang),) > CLANG_FLAGS += -no-integrated-as > +endif This is a nice suggestion and solution. Thanks Dima and Nathan. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Tested-by: Nick Desaulniers <ndesaulniers@google.com>
On Fri, Jun 28, 2019 at 4:15 AM Nathan Chancellor <natechancellor@gmail.com> wrote: > > There are some people interested in experimenting with Clang's > integrated assembler. To make it easy to do so without source > modification, allow the user to specify 'AS=clang' as part of the > make command to avoid adding '-no-integrated-as' to the {A,C}FLAGS. > > Link: https://github.com/ClangBuiltLinux/linux/issues/577 > Suggested-by: Dmitry Golovin <dima@golovin.in> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Applied to linux-kbuild. Thanks. > --- > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index 5102b2bbd224..d77481129339 100644 > --- a/Makefile > +++ b/Makefile > @@ -527,7 +527,9 @@ endif > ifneq ($(GCC_TOOLCHAIN),) > CLANG_FLAGS += --gcc-toolchain=$(GCC_TOOLCHAIN) > endif > +ifeq ($(shell $(AS) --version 2>&1 | head -n 1 | grep clang),) > CLANG_FLAGS += -no-integrated-as > +endif > CLANG_FLAGS += -Werror=unknown-warning-option > KBUILD_CFLAGS += $(CLANG_FLAGS) > KBUILD_AFLAGS += $(CLANG_FLAGS) > -- > 2.22.0 > -- Best Regards Masahiro Yamada
diff --git a/Makefile b/Makefile index 5102b2bbd224..d77481129339 100644 --- a/Makefile +++ b/Makefile @@ -527,7 +527,9 @@ endif ifneq ($(GCC_TOOLCHAIN),) CLANG_FLAGS += --gcc-toolchain=$(GCC_TOOLCHAIN) endif +ifeq ($(shell $(AS) --version 2>&1 | head -n 1 | grep clang),) CLANG_FLAGS += -no-integrated-as +endif CLANG_FLAGS += -Werror=unknown-warning-option KBUILD_CFLAGS += $(CLANG_FLAGS) KBUILD_AFLAGS += $(CLANG_FLAGS)
There are some people interested in experimenting with Clang's integrated assembler. To make it easy to do so without source modification, allow the user to specify 'AS=clang' as part of the make command to avoid adding '-no-integrated-as' to the {A,C}FLAGS. Link: https://github.com/ClangBuiltLinux/linux/issues/577 Suggested-by: Dmitry Golovin <dima@golovin.in> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- Makefile | 2 ++ 1 file changed, 2 insertions(+)