From patchwork Mon Feb 10 13:19:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sami Tolvanen X-Patchwork-Id: 11373259 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E0FCF1820 for ; Mon, 10 Feb 2020 13:19:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C200520863 for ; Mon, 10 Feb 2020 13:19:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SCqH2t8U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729054AbgBJNTg (ORCPT ); Mon, 10 Feb 2020 08:19:36 -0500 Received: from mail-pg1-f201.google.com ([209.85.215.201]:39126 "EHLO mail-pg1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731021AbgBJNTc (ORCPT ); Mon, 10 Feb 2020 08:19:32 -0500 Received: by mail-pg1-f201.google.com with SMTP id r192so5423282pgr.6 for ; Mon, 10 Feb 2020 05:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=Fp6MtkUYwRFvvO6uysN//Mlb4ErU1o3j/TgE2RsZDqc=; b=SCqH2t8UW6xatENC08Bks3adEsYcqzl2ydiPjVd95yGYrm1qIPiqIPbJGbPVxOF6N2 cXPbr0IBQt6dB17hHDgfd7lRJkGVI8DYoUS5n63DYtkgFOIwvdhZ4zPcFPoI0T3hy5Ru 6h8p3HBYl6detqUKT0QbLofddrSssB4yFaWoDFUGUSGu97IlPbNCrhSuGmYn4FHcG1Hu puJqSk26531IpGVb/Z3XJbtj1Anubf+qN498+feR4jcBVrOGxmmypaTnM+V8YSvdXS+8 SHA1BEgWGjY6fO803XdXZJebU+i8hOLqSyWNeDAD1CXw0/l1mii1pe9nnC4ZqkDQ7Czy dtpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=Fp6MtkUYwRFvvO6uysN//Mlb4ErU1o3j/TgE2RsZDqc=; b=KeWZ+zmK+jqgZbsYoYVHbj7VslEJfcXQwK9eHe8QRJYnwh09ClTCuC1DfOhX+V/HxD DsYCG+oYTN4QEXgsc1NFHjEJZJMjwv2tWYQ5ZYV4p+auaglKemdOqzEnpvY7gn6fI+Ac TeBMTSKOT6Nr+7NHptbRRAyHXEyGeKBJhOnjjgz5ES6KY6q8JNx+1e/c1spy8iEtvCzH JGbuVFXIMUpgYcVURj6A1zPA64AVelG72/zSMWISfWixRWYLG0+fkyJRr39iZ+SBg/3E f24bH5c3t0eP+i0sG0e8aJEPoxp80+PjFqdF3VzIUk7WHeWi5qiTYCjD1A7Ow+bhnI/8 AFjQ== X-Gm-Message-State: APjAAAWnuRkZCUhMxpkA3kAeJIAyuJtWSwgy8Q3ZQpMmUrmOHe2S5JJd xiB/LcAK0JthH0ktnERxsCi/8etWOtQvuQYQ+Fk= X-Google-Smtp-Source: APXvYqweHMPn9EpO/hdGK4qeZV47ZWtBbfoAGJfRDlgtpjNgGjfNxpzn3TtErZABuInYR5PUZtGfkXcKDV0cYKcp4Kw= X-Received: by 2002:a63:ed01:: with SMTP id d1mr1488010pgi.95.1581340769935; Mon, 10 Feb 2020 05:19:29 -0800 (PST) Date: Mon, 10 Feb 2020 05:19:25 -0800 Message-Id: <20200210131925.145463-1-samitolvanen@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.25.0.341.g760bfbb309-goog Subject: [PATCH] kbuild: remove duplicate dependencies from .mod files From: Sami Tolvanen To: Masahiro Yamada , Michal Marek Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Sami Tolvanen Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org With CONFIG_TRIM_UNUSED_SYMS, if a module has enough dependencies to exceed the default xargs command line size limit, the output is split into multiple lines, which can result in used symbols getting trimmed. This change removes duplicate dependencies, which will reduce the probability of this happening and makes .mod files smaller and easier to read. Signed-off-by: Sami Tolvanen --- scripts/Makefile.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9 diff --git a/scripts/Makefile.build b/scripts/Makefile.build index a1730d42e5f3..a083bcec19d3 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -257,7 +257,7 @@ endef # List module undefined symbols (or empty line if not enabled) ifdef CONFIG_TRIM_UNUSED_KSYMS -cmd_undef_syms = $(NM) $< | sed -n 's/^ *U //p' | xargs echo +cmd_undef_syms = $(NM) $< | sed -n 's/^ *U //p' | sort -u | xargs echo else cmd_undef_syms = echo endif