| Message ID | 20200427003019.2401592-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kbuild: remove unused AS assignment | expand |
On Mon, Apr 27, 2020 at 09:30:19AM +0900, Masahiro Yamada wrote: > $(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove > AS variable") killed it. > > Remove the left-over code in arch/{arm,arm64}/Makefile. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
On Mon, Apr 27, 2020 at 09:30:19AM +0900, Masahiro Yamada wrote: > $(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove > AS variable") killed it. > > Remove the left-over code in arch/{arm,arm64}/Makefile. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > arch/arm/Makefile | 2 -- > arch/arm64/Makefile | 2 -- > 2 files changed, 4 deletions(-) Acked-by: Will Deacon <will@kernel.org> (If you post the arm64 part as a separate patch, I can pick it up) Will
On Mon, Apr 27, 2020 at 5:06 PM Will Deacon <will@kernel.org> wrote: > > On Mon, Apr 27, 2020 at 09:30:19AM +0900, Masahiro Yamada wrote: > > $(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove > > AS variable") killed it. > > > > Remove the left-over code in arch/{arm,arm64}/Makefile. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > --- > > > > arch/arm/Makefile | 2 -- > > arch/arm64/Makefile | 2 -- > > 2 files changed, 4 deletions(-) > > Acked-by: Will Deacon <will@kernel.org> > > (If you post the arm64 part as a separate patch, I can pick it up) This is just a trivial cleanup patch. So, I do not split it per-arch. Applied to linux-kbuild.
diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 7d5cd0f85461..cd28211f1418 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -45,12 +45,10 @@ endif ifeq ($(CONFIG_CPU_BIG_ENDIAN),y) KBUILD_CPPFLAGS += -mbig-endian CHECKFLAGS += -D__ARMEB__ -AS += -EB KBUILD_LDFLAGS += -EB else KBUILD_CPPFLAGS += -mlittle-endian CHECKFLAGS += -D__ARMEL__ -AS += -EL KBUILD_LDFLAGS += -EL endif diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 85e4149cc5d5..d86cc9137539 100644 --- a/arch/arm64/Makefile +++ b/arch/arm64/Makefile @@ -84,7 +84,6 @@ KBUILD_CFLAGS += $(branch-prot-flags-y) ifeq ($(CONFIG_CPU_BIG_ENDIAN), y) KBUILD_CPPFLAGS += -mbig-endian CHECKFLAGS += -D__AARCH64EB__ -AS += -EB # Prefer the baremetal ELF build target, but not all toolchains include # it so fall back to the standard linux version if needed. KBUILD_LDFLAGS += -EB $(call ld-option, -maarch64elfb, -maarch64linuxb) @@ -92,7 +91,6 @@ UTS_MACHINE := aarch64_be else KBUILD_CPPFLAGS += -mlittle-endian CHECKFLAGS += -D__AARCH64EL__ -AS += -EL # Same as above, prefer ELF but fall back to linux target if needed. KBUILD_LDFLAGS += -EL $(call ld-option, -maarch64elf, -maarch64linux) UTS_MACHINE := aarch64
$(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove AS variable") killed it. Remove the left-over code in arch/{arm,arm64}/Makefile. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- arch/arm/Makefile | 2 -- arch/arm64/Makefile | 2 -- 2 files changed, 4 deletions(-)