diff mbox series

[11/29] modpost: pass -N option only for modules modpost

Message ID	20200517094859.2376211-12-masahiroy@kernel.org (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=d4Bn=67=vger.kernel.org=linux-kbuild-owner@kernel.org> From: Masahiro Yamada <masahiroy@kernel.org> To: linux-kbuild@vger.kernel.org Cc: Jessica Yu <jeyu@kernel.org>, Masahiro Yamada <masahiroy@kernel.org>, Michal Marek <michal.lkml@markovi.net>, linux-kernel@vger.kernel.org Subject: [PATCH 11/29] modpost: pass -N option only for modules modpost Date: Sun, 17 May 2020 18:48:41 +0900 Message-Id: <20200517094859.2376211-12-masahiroy@kernel.org> In-Reply-To: <20200517094859.2376211-1-masahiroy@kernel.org> References: <20200517094859.2376211-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk
Series	modpost: various fixes, cleanups, optimizations \| expand [00/29] modpost: various fixes, cleanups, optimizations [01/29] modpost: drop RCS/CVS $Revision handling in MODULE_VERSION() [02/29] modpost: do not call get_modinfo() for vmlinux [03/29] modpost: add read_text_file() and get_line() helpers [04/29] modpost: fix potential mmap'ed file overrun in get_src_version() [05/29] modpost: re-add warning about missing *.mod file [06/29] modpost: avoid false-positive file open error [07/29] modpost: use read_text_file() and get_line() for reading text files [08/29] modpost: remove get_next_text() and make {grab,release_}file static [09/29] kbuild: disallow multi-word in M= or KBUILD_EXTMOD [10/29] modpost: move -T option close to the modpost command [11/29] modpost: pass -N option only for modules modpost [12/29] modpost: move external module options [13/29] modpost: load KBUILD_EXTRA_SYMBOLS files in order [14/29] modpost: track if the symbol origin is a dump file or ELF object [15/29] modpost: allow to pass -i option multiple times remove -e option [16/29] modpost: rename ext_sym_list to dump_list [17/29] modpost: re-add -e to set external_module flag [18/29] modpost: show warning if vmlinux is not found when processing modules [19/29] modpost: show warning if it fails to read symbol dump file [20/29] modpost: generate vmlinux.symvers and reuse it for the second modpost [21/29] modpost: remove -s option [22/29] modpost: remove mod->is_dot_o struct member [23/29] modpost: remove is_vmlinux() call in check_for_{gpl_usage,unused}() [24/29] modpost: add mod->is_vmlinux struct member [25/29] modpost: remove mod->skip struct member [26/29] modpost: set have_vmlinux in new_module() [27/29] modpost: strip .o from modname before calling new_module() [28/29] modpost: remove is_vmlinux() helper [29/29] modpost: change elf_info->size to size_t

Commit Message

Masahiro Yamada May 17, 2020, 9:48 a.m. UTC

The built-in only code is not required to have MODULE_IMPORT_NS() to
use symbols. So, the namespace is not checked for vmlinux(.o).

Do not pass the meaningless -N option to the first pass of modpost.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/Makefile.modpost | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
index da7730a43819..bc5561aedb24 100644
--- a/scripts/Makefile.modpost
+++ b/scripts/Makefile.modpost
@@ -53,7 +53,6 @@  MODPOST = scripts/mod/modpost								\
 	$(if $(KBUILD_EXTMOD),$(addprefix -e ,$(KBUILD_EXTRA_SYMBOLS)))			\
 	$(if $(KBUILD_EXTMOD),-o $(modulesymfile))					\
 	$(if $(CONFIG_SECTION_MISMATCH_WARN_ONLY),,-E)					\
-	$(if $(CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS)$(KBUILD_NSDEPS),-N) 	\
 	$(if $(KBUILD_MODPOST_WARN),-w)
 
 ifdef MODPOST_VMLINUX
@@ -66,7 +65,9 @@  __modpost:
 
 else
 
+# modpost options for modules (both in-kernel and external)
 MODPOST += $(subst -i,-n,$(filter -i,$(MAKEFLAGS))) -s \
+	$(if $(CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS)$(KBUILD_NSDEPS),-N) \
 	$(if $(KBUILD_NSDEPS),-d $(MODULES_NSDEPS))
 
 ifeq ($(KBUILD_EXTMOD),)