From patchwork Wed Jul 29 03:18:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 11690237 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D8E8B1392 for ; Wed, 29 Jul 2020 03:18:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF6A3207E8 for ; Wed, 29 Jul 2020 03:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595992739; bh=Ohpr+GqDnJEOLdgLCpq4Gz/ax0rPukQmUk2OhLp6S8E=; h=From:To:Cc:Subject:Date:List-ID:From; b=1HjBQm5TYJrdNPmTW8kuvIsWvj2miWaFeWNXE1F1KQaybfumVAZMGvN+xykgv+laX sd1qGddbxBpHFvtVXMe5x9vZyPQiQgVjPjrQJr5irrOQP2Gs3q5LKqnz4Cs2XsH0hz 2q1fI3FuqDZh62mt13POKB5V+MPT/x9ErqdgMRjI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726245AbgG2DS7 (ORCPT ); Tue, 28 Jul 2020 23:18:59 -0400 Received: from conuserg-09.nifty.com ([210.131.2.76]:54949 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726047AbgG2DS7 (ORCPT ); Tue, 28 Jul 2020 23:18:59 -0400 Received: from oscar.flets-west.jp (softbank126025067101.bbtec.net [126.25.67.101]) (authenticated) by conuserg-09.nifty.com with ESMTP id 06T3Idoj022954; Wed, 29 Jul 2020 12:18:40 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com 06T3Idoj022954 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1595992720; bh=R9y5zPXSYlxpJC3uaZU9/XIf/pq603Add2HzPoAewpI=; h=From:To:Cc:Subject:Date:From; b=i14gl6ihxmctLPcBS4tyt+p7/WdzTb7gdQqoN4CjRKEYy99nijfWflLwkrfcRD2X1 G+4j3pu55azA3t8ph7wLBywO2Dcd/pvzLC/irFfQiYNAjJoSpoXuAsA/1/znT+EggF SsHJlTseZxGrnRfsRyVFA4JFJuwtKhZKjr8i7cl+02FSh5Kg6ztLyiSk7if7oiFHmt ZcpFm8PCyIrC+Yl3W0Ez7oO4/mZ5dYqC1nI/a7oL5Sutn73HLRGTIJf6dEioLKzJ0W zg5qNBqEvagB3zmpiiP/6cLTHwdaHDzhOQDDnGpUDvyRhvdwtFD8tPfF9fdyOkt2Q1 h8qG/yBCGD29Q== X-Nifty-SrcIP: [126.25.67.101] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH] kconfig: add 'static' to some file-local data Date: Wed, 29 Jul 2020 12:18:37 +0900 Message-Id: <20200729031838.38238-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org Fix some warnings from sparce like follows: warning: symbol '...' was not declared. Should it be static? Signed-off-by: Masahiro Yamada --- scripts/kconfig/lexer.l | 2 +- scripts/kconfig/symbol.c | 14 ++++++++++---- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/scripts/kconfig/lexer.l b/scripts/kconfig/lexer.l index 6354c905b006..98daac3bc829 100644 --- a/scripts/kconfig/lexer.l +++ b/scripts/kconfig/lexer.l @@ -36,7 +36,7 @@ struct buffer { YY_BUFFER_STATE state; }; -struct buffer *current_buf; +static struct buffer *current_buf; static int last_ts, first_ts; diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c index 9363e37b8870..ffa3ec65cc90 100644 --- a/scripts/kconfig/symbol.c +++ b/scripts/kconfig/symbol.c @@ -15,15 +15,21 @@ struct symbol symbol_yes = { .name = "y", .curr = { "y", yes }, .flags = SYMBOL_CONST|SYMBOL_VALID, -}, symbol_mod = { +}; + +struct symbol symbol_mod = { .name = "m", .curr = { "m", mod }, .flags = SYMBOL_CONST|SYMBOL_VALID, -}, symbol_no = { +}; + +struct symbol symbol_no = { .name = "n", .curr = { "n", no }, .flags = SYMBOL_CONST|SYMBOL_VALID, -}, symbol_empty = { +}; + +static struct symbol symbol_empty = { .name = "", .curr = { "", no }, .flags = SYMBOL_VALID, @@ -31,7 +37,7 @@ struct symbol symbol_yes = { struct symbol *sym_defconfig_list; struct symbol *modules_sym; -tristate modules_val; +static tristate modules_val; enum symbol_type sym_get_type(struct symbol *sym) {