| Message ID | 20201201165222.2001985-1-qperret@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] modpost: turn static exports into error | expand |
On Wed, Dec 2, 2020 at 1:52 AM Quentin Perret <qperret@google.com> wrote: > > Using EXPORT_SYMBOL*() on static functions is fundamentally wrong. > Modpost currently reports that as a warning, but clearly this is not a > pattern we should allow, and all in-tree occurences should have been > fixed by now. So, promote the warn() message to error() to make sure > this never happens again. > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Reviewed-by: Matthias Maennich <maennich@google.com> > Signed-off-by: Quentin Perret <qperret@google.com> > > --- > v2: now depends on 20201201103418.675850-2-masahiroy@kernel.org Applied to linux-kbuild. Thanks. > --- > scripts/mod/modpost.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index 43e00867623a..5562526c8c32 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -2648,9 +2648,9 @@ int main(int argc, char **argv) > > for (s = symbolhash[n]; s; s = s->next) { > if (s->is_static) > - warn("\"%s\" [%s] is a static %s\n", > - s->name, s->module->name, > - export_str(s->export)); > + error("\"%s\" [%s] is a static %s\n", > + s->name, s->module->name, > + export_str(s->export)); > } > } > > -- > 2.29.2.454.gaff20da3a2-goog >
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 43e00867623a..5562526c8c32 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2648,9 +2648,9 @@ int main(int argc, char **argv) for (s = symbolhash[n]; s; s = s->next) { if (s->is_static) - warn("\"%s\" [%s] is a static %s\n", - s->name, s->module->name, - export_str(s->export)); + error("\"%s\" [%s] is a static %s\n", + s->name, s->module->name, + export_str(s->export)); } }