diff mbox series

kconfig: config script: add a little user help

Message ID 20201219055947.29587-1-rdunlap@infradead.org (mailing list archive)
State New
Headers show
Series kconfig: config script: add a little user help | expand

Commit Message

Randy Dunlap Dec. 19, 2020, 5:59 a.m. UTC
Give the user a clue about the problem along with the 35 lines of
usage/help text.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org
---
 scripts/config |    1 +
 1 file changed, 1 insertion(+)

Comments

Masahiro Yamada Dec. 19, 2020, 3:47 p.m. UTC | #1
On Sat, Dec 19, 2020 at 3:00 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Give the user a clue about the problem along with the 35 lines of
> usage/help text.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: linux-kbuild@vger.kernel.org
> ---
>  scripts/config |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20201218.orig/scripts/config
> +++ linux-next-20201218/scripts/config
> @@ -223,6 +223,7 @@ while [ "$1" != "" ] ; do
>                 ;;
>
>         *)
> +               echo "bad cmd: $CMD"

Please send this to stderr.



>                 usage
>                 ;;
>         esac
Masahiro Yamada Dec. 19, 2020, 3:57 p.m. UTC | #2
On Sun, Dec 20, 2020 at 12:47 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Sat, Dec 19, 2020 at 3:00 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > Give the user a clue about the problem along with the 35 lines of
> > usage/help text.
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Andi Kleen <ak@linux.intel.com>
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Cc: linux-kbuild@vger.kernel.org
> > ---
> >  scripts/config |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > --- linux-next-20201218.orig/scripts/config
> > +++ linux-next-20201218/scripts/config
> > @@ -223,6 +223,7 @@ while [ "$1" != "" ] ; do
> >                 ;;
> >
> >         *)
> > +               echo "bad cmd: $CMD"
>
> Please send this to stderr.


Also, "bad command" instead of "bad cmd"




>
>
>
> >                 usage
> >                 ;;
> >         esac
>
>
>
> --
> Best Regards
> Masahiro Yamada
diff mbox series

Patch

--- linux-next-20201218.orig/scripts/config
+++ linux-next-20201218/scripts/config
@@ -223,6 +223,7 @@  while [ "$1" != "" ] ; do
 		;;
 
 	*)
+		echo "bad cmd: $CMD"
 		usage
 		;;
 	esac