diff mbox series

scripts: kconfig: fix HOSTCC call

Message ID 20210114100216.11787-1-info@metux.net (mailing list archive)
State New
Headers show
Series scripts: kconfig: fix HOSTCC call | expand

Commit Message

Enrico Weigelt, metux IT consult Jan. 14, 2021, 10:02 a.m. UTC
The change c0f975af1745391749e4306aa8081b9a4d2cced8 introduces a bug when
HOSTCC contains parameters: the whole command line is treated as the program
name (with spaces in it). Therefore, we have to remove the quotes.

Fixes: c0f975af1745391749e4306aa8081b9a4d2cced8
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 scripts/kconfig/mconf-cfg.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Masahiro Yamada Jan. 14, 2021, 7 p.m. UTC | #1
On Thu, Jan 14, 2021 at 7:05 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>

Thanks for catching this.


> The change c0f975af1745391749e4306aa8081b9a4d2cced8 introduces a bug when

Please use 12-digit hash ("subject") style.


Commit c0f975af1745 ("kconfig: Support building mconf with vendor
sysroot ncurses")



> HOSTCC contains parameters: the whole command line is treated as the program
> name (with spaces in it). Therefore, we have to remove the quotes.
>
> Fixes: c0f975af1745391749e4306aa8081b9a4d2cced8

Ditto.

Fixes: c0f975af1745 ("kconfig: Support building mconf with vendor
sysroot ncurses")



> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
>  scripts/kconfig/mconf-cfg.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
> index fcd4acd4e9cb..40fa449ed049 100755
> --- a/scripts/kconfig/mconf-cfg.sh
> +++ b/scripts/kconfig/mconf-cfg.sh
> @@ -35,7 +35,7 @@ fi
>
>  # As a final fallback before giving up, check if $HOSTCC knows of a default
>  # ncurses installation (e.g. from a vendor-specific sysroot).
> -if echo '#include <ncurses.h>' | "${HOSTCC}" -E - >/dev/null 2>&1; then
> +if echo '#include <ncurses.h>' | ${HOSTCC} -E - >/dev/null ; then


Please keep 2>&1.

This script will display the enough error message at the end.



>         echo cflags=\"-D_GNU_SOURCE\"
>         echo libs=\"-lncurses\"
>         exit 0
> --
> 2.11.0
>
Masahiro Yamada Jan. 26, 2021, 6:16 p.m. UTC | #2
On Fri, Jan 15, 2021 at 4:00 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Thu, Jan 14, 2021 at 7:05 PM Enrico Weigelt, metux IT consult
> <info@metux.net> wrote:
> >
>
> Thanks for catching this.
>
>
> > The change c0f975af1745391749e4306aa8081b9a4d2cced8 introduces a bug when
>
> Please use 12-digit hash ("subject") style.
>
>
> Commit c0f975af1745 ("kconfig: Support building mconf with vendor
> sysroot ncurses")
>
>
>
> > HOSTCC contains parameters: the whole command line is treated as the program
> > name (with spaces in it). Therefore, we have to remove the quotes.
> >
> > Fixes: c0f975af1745391749e4306aa8081b9a4d2cced8
>
> Ditto.
>
> Fixes: c0f975af1745 ("kconfig: Support building mconf with vendor
> sysroot ncurses")
>
>
>
> > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> > ---
> >  scripts/kconfig/mconf-cfg.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
> > index fcd4acd4e9cb..40fa449ed049 100755
> > --- a/scripts/kconfig/mconf-cfg.sh
> > +++ b/scripts/kconfig/mconf-cfg.sh
> > @@ -35,7 +35,7 @@ fi
> >
> >  # As a final fallback before giving up, check if $HOSTCC knows of a default
> >  # ncurses installation (e.g. from a vendor-specific sysroot).
> > -if echo '#include <ncurses.h>' | "${HOSTCC}" -E - >/dev/null 2>&1; then
> > +if echo '#include <ncurses.h>' | ${HOSTCC} -E - >/dev/null ; then
>
>
> Please keep 2>&1.
>
> This script will display the enough error message at the end.
>
>
>
> >         echo cflags=\"-D_GNU_SOURCE\"
> >         echo libs=\"-lncurses\"
> >         exit 0
> > --
> > 2.11.0
> >
>
>
> --
> Best Regards
> Masahiro Yamada


I did not get v2.

I fixed them up by myself and applied it to linux-kbuild/fixes.
diff mbox series

Patch

diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
index fcd4acd4e9cb..40fa449ed049 100755
--- a/scripts/kconfig/mconf-cfg.sh
+++ b/scripts/kconfig/mconf-cfg.sh
@@ -35,7 +35,7 @@  fi
 
 # As a final fallback before giving up, check if $HOSTCC knows of a default
 # ncurses installation (e.g. from a vendor-specific sysroot).
-if echo '#include <ncurses.h>' | "${HOSTCC}" -E - >/dev/null 2>&1; then
+if echo '#include <ncurses.h>' | ${HOSTCC} -E - >/dev/null ; then
 	echo cflags=\"-D_GNU_SOURCE\"
 	echo libs=\"-lncurses\"
 	exit 0