diff mbox series

[v2] uml: fix W=1 missing-include-dirs warnings

Message ID 20210415171352.27398-1-rdunlap@infradead.org (mailing list archive)
State New
Headers show
Series [v2] uml: fix W=1 missing-include-dirs warnings | expand

Commit Message

Randy Dunlap April 15, 2021, 5:13 p.m. UTC
Currently when using "W=1" with UML builds, there are over 700 warnings
like so:

  CC      arch/um/drivers/stderr_console.o
cc1: warning: ./arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs]

but arch/um/ does not have include/uapi/ at all, so add that
subdir and put one Kbuild file into it (since git does not track
empty subdirs).

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>
Cc: linux-kbuild@vger.kernel.org
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: linux-um@lists.infradead.org
---
v2: use Option 4 from v1: add arch/um/include/uapi so that 'make' is
    placated -- and just like all other arch's have.

 arch/um/include/uapi/asm/Kbuild |    1 +
 1 file changed, 1 insertion(+)

Comments

Masahiro Yamada April 15, 2021, 7:14 p.m. UTC | #1
On Fri, Apr 16, 2021 at 2:14 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Currently when using "W=1" with UML builds, there are over 700 warnings
> like so:
>
>   CC      arch/um/drivers/stderr_console.o
> cc1: warning: ./arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs]
>
> but arch/um/ does not have include/uapi/ at all, so add that
> subdir and put one Kbuild file into it (since git does not track
> empty subdirs).
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Michal Marek <michal.lkml@markovi.net>
> Cc: linux-kbuild@vger.kernel.org
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> Cc: linux-um@lists.infradead.org
> ---
> v2: use Option 4 from v1: add arch/um/include/uapi so that 'make' is
>     placated -- and just like all other arch's have.



Assuming the UML maintainer will pick up this:

Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>







>  arch/um/include/uapi/asm/Kbuild |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/um/include/uapi/asm/Kbuild b/arch/um/include/uapi/asm/Kbuild
> new file mode 100644
> index 000000000000..f66554cd5c45
> --- /dev/null
> +++ b/arch/um/include/uapi/asm/Kbuild
> @@ -0,0 +1 @@
> +# SPDX-License-Identifier: GPL-2.0
Masahiro Yamada April 16, 2021, 5:51 a.m. UTC | #2
On Fri, Apr 16, 2021 at 4:14 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Fri, Apr 16, 2021 at 2:14 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > Currently when using "W=1" with UML builds, there are over 700 warnings
> > like so:
> >
> >   CC      arch/um/drivers/stderr_console.o
> > cc1: warning: ./arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs]
> >
> > but arch/um/ does not have include/uapi/ at all, so add that
> > subdir and put one Kbuild file into it (since git does not track
> > empty subdirs).
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Cc: Michal Marek <michal.lkml@markovi.net>
> > Cc: linux-kbuild@vger.kernel.org
> > Cc: Jeff Dike <jdike@addtoit.com>
> > Cc: Richard Weinberger <richard@nod.at>
> > Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> > Cc: linux-um@lists.infradead.org
> > ---
> > v2: use Option 4 from v1: add arch/um/include/uapi so that 'make' is
> >     placated -- and just like all other arch's have.
>
>
>
> Assuming the UML maintainer will pick up this:
>
> Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>


Now I see this patch queued up to UML repository.
Thanks.




--
Best Regards
Masahiro Yamada
Anton Ivanov April 16, 2021, 6:11 a.m. UTC | #3
On 15/04/2021 18:13, Randy Dunlap wrote:
> Currently when using "W=1" with UML builds, there are over 700 warnings
> like so:
>
>    CC      arch/um/drivers/stderr_console.o
> cc1: warning: ./arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs]
>
> but arch/um/ does not have include/uapi/ at all, so add that
> subdir and put one Kbuild file into it (since git does not track
> empty subdirs).
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Michal Marek <michal.lkml@markovi.net>
> Cc: linux-kbuild@vger.kernel.org
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> Cc: linux-um@lists.infradead.org
> ---
> v2: use Option 4 from v1: add arch/um/include/uapi so that 'make' is
>      placated -- and just like all other arch's have.
>
>   arch/um/include/uapi/asm/Kbuild |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/um/include/uapi/asm/Kbuild b/arch/um/include/uapi/asm/Kbuild
> new file mode 100644
> index 000000000000..f66554cd5c45
> --- /dev/null
> +++ b/arch/um/include/uapi/asm/Kbuild
> @@ -0,0 +1 @@
> +# SPDX-License-Identifier: GPL-2.0
>
> _______________________________________________
> linux-um mailing list
> linux-um@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-um
>
+1

I will forward it to openwrt-dev. Their build process adds uapi to uml, 
so if we are going to change this, it will be nice to give them a heads-up.

Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
diff mbox series

Patch

diff --git a/arch/um/include/uapi/asm/Kbuild b/arch/um/include/uapi/asm/Kbuild
new file mode 100644
index 000000000000..f66554cd5c45
--- /dev/null
+++ b/arch/um/include/uapi/asm/Kbuild
@@ -0,0 +1 @@ 
+# SPDX-License-Identifier: GPL-2.0