diff mbox series

[4/5] hexagon: move core-y in arch/hexagon/Makefile to arch/hexagon/Kbuild

Message ID 20210512075729.60291-4-masahiroy@kernel.org (mailing list archive)
State New, archived
Headers show
Series [1/5] kbuild: require all architectures to have arch/$(SRCARCH)/Kbuild | expand

Commit Message

Masahiro Yamada May 12, 2021, 7:57 a.m. UTC 
Use obj-y to clean up Makefile.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 arch/hexagon/Kbuild   | 1 +
 arch/hexagon/Makefile | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)

Comments

Nicolas Schier May 21, 2021, 10:29 a.m. UTC | #1 
Hi Masahiro,

On Wed 12 May 2021 16:57:28 GMT, Masahiro Yamada wrote:
> Use obj-y to clean up Makefile.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  arch/hexagon/Kbuild   | 1 +
>  arch/hexagon/Makefile | 4 ----
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/hexagon/Kbuild b/arch/hexagon/Kbuild
> index a4e40e534e6a..d930c2f954d5 100644
> --- a/arch/hexagon/Kbuild
> +++ b/arch/hexagon/Kbuild
> @@ -1 +1,2 @@
>  # SPDX-License-Identifier: GPL-2.0-only
> +obj += kernel/ mm/ lib/

This should probably be 'obj-y' instead of 'obj'?

Kind regards,
Nicolas
Masahiro Yamada May 22, 2021, 1:16 a.m. UTC | #2 
On Fri, May 21, 2021 at 7:30 PM Nicolas Schier <nicolas@fjasle.eu> wrote:
>
> Hi Masahiro,
>
> On Wed 12 May 2021 16:57:28 GMT, Masahiro Yamada wrote:
> > Use obj-y to clean up Makefile.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  arch/hexagon/Kbuild   | 1 +
> >  arch/hexagon/Makefile | 4 ----
> >  2 files changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/arch/hexagon/Kbuild b/arch/hexagon/Kbuild
> > index a4e40e534e6a..d930c2f954d5 100644
> > --- a/arch/hexagon/Kbuild
> > +++ b/arch/hexagon/Kbuild
> > @@ -1 +1,2 @@
> >  # SPDX-License-Identifier: GPL-2.0-only
> > +obj += kernel/ mm/ lib/
>
> This should probably be 'obj-y' instead of 'obj'?
>

Oops, thanks for catching that!
I will fix it when I apply it.
diff mbox series

Patch

diff --git a/arch/hexagon/Kbuild b/arch/hexagon/Kbuild
index a4e40e534e6a..d930c2f954d5 100644
--- a/arch/hexagon/Kbuild
+++ b/arch/hexagon/Kbuild
@@ -1 +1,2 @@ 
 # SPDX-License-Identifier: GPL-2.0-only
+obj += kernel/ mm/ lib/
diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile
index 74b644ea8a00..44312bc147d8 100644
--- a/arch/hexagon/Makefile
+++ b/arch/hexagon/Makefile
@@ -34,7 +34,3 @@  KBUILD_CFLAGS += -ffixed-$(TIR_NAME) -DTHREADINFO_REG=$(TIR_NAME) -D__linux__
 KBUILD_AFLAGS += -DTHREADINFO_REG=$(TIR_NAME)
 
 head-y := arch/hexagon/kernel/head.o
-
-core-y += arch/hexagon/kernel/ \
-	arch/hexagon/mm/ \
-	arch/hexagon/lib/