| Message ID | 20210917061104.2680133-6-brendanhiggins@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kunit: build kunit tests without structleak plugin | expand |
On Thu, Sep 16, 2021 at 11:11:03PM -0700, Brendan Higgins wrote: > The structleak plugin causes the stack frame size to grow immensely when > used with KUnit. > > Turn it off. > > Co-developed-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > --- > drivers/mmc/host/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile > index 14004cc09aaad..2ab083931f8fd 100644 > --- a/drivers/mmc/host/Makefile > +++ b/drivers/mmc/host/Makefile > @@ -85,6 +85,7 @@ obj-$(CONFIG_MMC_SDHCI_DOVE) += sdhci-dove.o > obj-$(CONFIG_MMC_SDHCI_TEGRA) += sdhci-tegra.o > obj-$(CONFIG_MMC_SDHCI_OF_ARASAN) += sdhci-of-arasan.o > obj-$(CONFIG_MMC_SDHCI_OF_ASPEED) += sdhci-of-aspeed.o > +CFLAGS_sdhci-of-aspeed.o += $(DISABLE_STRUCTLEAK_PLUGIN) This isn't a stand-alone test object, so I'm less excited about disabling STRUCTLEAK here. > obj-$(CONFIG_MMC_SDHCI_OF_AT91) += sdhci-of-at91.o > obj-$(CONFIG_MMC_SDHCI_OF_ESDHC) += sdhci-of-esdhc.o > obj-$(CONFIG_MMC_SDHCI_OF_HLWD) += sdhci-of-hlwd.o > -- > 2.33.0.464.g1972c5931b-goog >
On Fri, Sep 17, 2021 at 8:57 AM Kees Cook <keescook@chromium.org> wrote: > > This isn't a stand-alone test object, so I'm less excited about > disabling STRUCTLEAK here. Yeah, please don't do this for things that aren't pure tests. You're now disabling security measures (even if I hate the gcc plugins and hope they will go away). Linus
On Fri, Sep 17, 2021 at 11:40 AM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > On Fri, Sep 17, 2021 at 8:57 AM Kees Cook <keescook@chromium.org> wrote: > > > > This isn't a stand-alone test object, so I'm less excited about > > disabling STRUCTLEAK here. > > Yeah, please don't do this for things that aren't pure tests. You're > now disabling security measures (even if I hate the gcc plugins and > hope they will go away). Oh, whoops, yeah, I shouldn't do that. I am just going to drop this patch entirely, as I wasn't able to reproduce the stack frame size issue on qemu anyway (as I mentioned on the cover letter). Thanks for catching this. Sorry!
diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile index 14004cc09aaad..2ab083931f8fd 100644 --- a/drivers/mmc/host/Makefile +++ b/drivers/mmc/host/Makefile @@ -85,6 +85,7 @@ obj-$(CONFIG_MMC_SDHCI_DOVE) += sdhci-dove.o obj-$(CONFIG_MMC_SDHCI_TEGRA) += sdhci-tegra.o obj-$(CONFIG_MMC_SDHCI_OF_ARASAN) += sdhci-of-arasan.o obj-$(CONFIG_MMC_SDHCI_OF_ASPEED) += sdhci-of-aspeed.o +CFLAGS_sdhci-of-aspeed.o += $(DISABLE_STRUCTLEAK_PLUGIN) obj-$(CONFIG_MMC_SDHCI_OF_AT91) += sdhci-of-at91.o obj-$(CONFIG_MMC_SDHCI_OF_ESDHC) += sdhci-of-esdhc.o obj-$(CONFIG_MMC_SDHCI_OF_HLWD) += sdhci-of-hlwd.o
The structleak plugin causes the stack frame size to grow immensely when used with KUnit. Turn it off. Co-developed-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Brendan Higgins <brendanhiggins@google.com> --- drivers/mmc/host/Makefile | 1 + 1 file changed, 1 insertion(+)