| Message ID | 20211008215133.9371-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | um: Add missing "FORCE" target when using if_changed | expand |
On Sat, Oct 9, 2021 at 5:51 AM Randy Dunlap <rdunlap@infradead.org> wrote: > > 'make ARCH=um' says: > > ../arch/x86/um/Makefile:44: FORCE prerequisite is missing > > and adding "FORCE" there makes it be quiet, so do it. :) > > Fixes: e1f86d7b4b2a ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and filechk") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Masahiro Yamada <masahiroy@kernel.org> > Cc: Michal Marek <michal.lkml@markovi.net> > Cc: Nick Desaulniers <ndesaulniers@google.com> > Cc: linux-kbuild@vger.kernel.org > Cc: Jeff Dike <jdike@addtoit.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> > Cc: linux-um@lists.infradead.org > Cc: x86@kernel.org > --- FYI, this looks identical to "uml: x86: add FORCE to user_constants.h": http://lists.infradead.org/pipermail/linux-um/2021-September/001791.html -- David
On 10/8/21 4:23 PM, David Gow wrote: > On Sat, Oct 9, 2021 at 5:51 AM Randy Dunlap <rdunlap@infradead.org> wrote: >> >> 'make ARCH=um' says: >> >> ../arch/x86/um/Makefile:44: FORCE prerequisite is missing >> >> and adding "FORCE" there makes it be quiet, so do it. :) >> >> Fixes: e1f86d7b4b2a ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and filechk") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Masahiro Yamada <masahiroy@kernel.org> >> Cc: Michal Marek <michal.lkml@markovi.net> >> Cc: Nick Desaulniers <ndesaulniers@google.com> >> Cc: linux-kbuild@vger.kernel.org >> Cc: Jeff Dike <jdike@addtoit.com> >> Cc: Richard Weinberger <richard@nod.at> >> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> >> Cc: linux-um@lists.infradead.org >> Cc: x86@kernel.org >> --- > > FYI, this looks identical to "uml: x86: add FORCE to user_constants.h": > http://lists.infradead.org/pipermail/linux-um/2021-September/001791.html Oh, thanks for that. Maintainers?...
On 09/10/2021 01:01, Randy Dunlap wrote: > On 10/8/21 4:23 PM, David Gow wrote: >> On Sat, Oct 9, 2021 at 5:51 AM Randy Dunlap <rdunlap@infradead.org> >> wrote: >>> >>> 'make ARCH=um' says: >>> >>> ../arch/x86/um/Makefile:44: FORCE prerequisite is missing >>> >>> and adding "FORCE" there makes it be quiet, so do it. :) >>> >>> Fixes: e1f86d7b4b2a ("kbuild: warn if FORCE is missing for >>> if_changed(_dep,_rule) and filechk") >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>> Cc: Masahiro Yamada <masahiroy@kernel.org> >>> Cc: Michal Marek <michal.lkml@markovi.net> >>> Cc: Nick Desaulniers <ndesaulniers@google.com> >>> Cc: linux-kbuild@vger.kernel.org >>> Cc: Jeff Dike <jdike@addtoit.com> >>> Cc: Richard Weinberger <richard@nod.at> >>> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> >>> Cc: linux-um@lists.infradead.org >>> Cc: x86@kernel.org >>> --- >> >> FYI, this looks identical to "uml: x86: add FORCE to user_constants.h": >> http://lists.infradead.org/pipermail/linux-um/2021-September/001791.html > > Oh, thanks for that. > > Maintainers?... > The patch by Johannes is not in the pending list in patchwork, so it looks like Richard has processed it and it will be in the next pull request. Brgds,
On 9 October 2021 07:36:36 CEST, Anton Ivanov <anton.ivanov@cambridgegreys.com> wrote: >The patch by Johannes is not in the pending list in patchwork, so it >looks like Richard has processed it and it will be in the next pull request. I think it's still open: https://patchwork.ozlabs.org/project/linux-um/patch/20210928115146.277bec2328bb.If70926505d16d6c6a229002eb6d3f6838b546175@changeid/ johannes
----- Ursprüngliche Mail ----- > Von: "Johannes Berg" <johannes@sipsolutions.net> > An: "anton ivanov" <anton.ivanov@cambridgegreys.com>, "Randy Dunlap" <rdunlap@infradead.org>, "davidgow" > <davidgow@google.com> > CC: "masahiroy" <masahiroy@kernel.org>, "Michal Marek" <michal.lkml@markovi.net>, "Nick Desaulniers" > <ndesaulniers@google.com>, "linux-kbuild" <linux-kbuild@vger.kernel.org>, "Jeff Dike" <jdike@addtoit.com>, "richard" > <richard@nod.at>, "linux-um" <linux-um@lists.infradead.org>, "x86" <x86@kernel.org> > Gesendet: Samstag, 9. Oktober 2021 15:06:01 > Betreff: Re: [PATCH] um: Add missing "FORCE" target when using if_changed > On 9 October 2021 07:36:36 CEST, Anton Ivanov <anton.ivanov@cambridgegreys.com> > wrote: > >>The patch by Johannes is not in the pending list in patchwork, so it >>looks like Richard has processed it and it will be in the next pull request. > > I think it's still open: > https://patchwork.ozlabs.org/project/linux-um/patch/20210928115146.277bec2328bb.If70926505d16d6c6a229002eb6d3f6838b546175@changeid/ This patch is now in linux-next. Thanks, //richard
--- linux-next-20211007.orig/arch/x86/um/Makefile +++ linux-next-20211007/arch/x86/um/Makefile @@ -40,7 +40,7 @@ $(obj)/user-offsets.s: c_flags = -Wp,-MD -Iarch/x86/include/generated targets += user-offsets.s -include/generated/user_constants.h: $(obj)/user-offsets.s +include/generated/user_constants.h: $(obj)/user-offsets.s FORCE $(call filechk,offsets,__USER_CONSTANT_H__) UNPROFILE_OBJS := stub_segv.o
'make ARCH=um' says: ../arch/x86/um/Makefile:44: FORCE prerequisite is missing and adding "FORCE" there makes it be quiet, so do it. :) Fixes: e1f86d7b4b2a ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and filechk") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Michal Marek <michal.lkml@markovi.net> Cc: Nick Desaulniers <ndesaulniers@google.com> Cc: linux-kbuild@vger.kernel.org Cc: Jeff Dike <jdike@addtoit.com> Cc: Richard Weinberger <richard@nod.at> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> Cc: linux-um@lists.infradead.org Cc: x86@kernel.org --- arch/x86/um/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)