| Message ID | 20220424190811.1678416-4-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kbuild: yet another series of cleanups (modpost and LTO) | expand |
On Sun, Apr 24, 2022 at 12:09 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > The description, > > it may have already been added without a > CRC, in this case just update the CRC > > ... is no longer valid. > > In very old days, this function was used to update the CRC as well. > > Commit 040fcc819a2e ("kbuild: improved modversioning support for > external modules") started to use a separate function (sym_update_crc) > for updating the CRC. > > The first part, "Add an exported symbol" is correct, but it is too > obvious from the function name. Drop this comment entirely. Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > scripts/mod/modpost.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index f0d48f65fb33..c7cfeeb088f7 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -387,10 +387,6 @@ static void sym_update_namespace(const char *symname, const char *namespace) > s->namespace = namespace[0] ? NOFAIL(strdup(namespace)) : NULL; > } > > -/** > - * Add an exported symbol - it may have already been added without a > - * CRC, in this case just update the CRC > - **/ > static struct symbol *sym_add_exported(const char *name, struct module *mod, > enum export export) > { > -- > 2.32.0 >
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index f0d48f65fb33..c7cfeeb088f7 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -387,10 +387,6 @@ static void sym_update_namespace(const char *symname, const char *namespace) s->namespace = namespace[0] ? NOFAIL(strdup(namespace)) : NULL; } -/** - * Add an exported symbol - it may have already been added without a - * CRC, in this case just update the CRC - **/ static struct symbol *sym_add_exported(const char *name, struct module *mod, enum export export) {
The description, it may have already been added without a CRC, in this case just update the CRC ... is no longer valid. In very old days, this function was used to update the CRC as well. Commit 040fcc819a2e ("kbuild: improved modversioning support for external modules") started to use a separate function (sym_update_crc) for updating the CRC. The first part, "Add an exported symbol" is correct, but it is too obvious from the function name. Drop this comment entirely. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- scripts/mod/modpost.c | 4 ---- 1 file changed, 4 deletions(-)