From patchwork Thu Jun 16 19:57:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sami Tolvanen X-Patchwork-Id: 12884717 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4415C43334 for ; Thu, 16 Jun 2022 19:58:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378361AbiFPT6J (ORCPT ); Thu, 16 Jun 2022 15:58:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349656AbiFPT6J (ORCPT ); Thu, 16 Jun 2022 15:58:09 -0400 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B53029C89 for ; Thu, 16 Jun 2022 12:58:04 -0700 (PDT) Received: by mail-pg1-x549.google.com with SMTP id 20-20020a630114000000b00408e3bb6343so1163223pgb.6 for ; Thu, 16 Jun 2022 12:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=ldQA7TEIhVlvvX0NA61TMlZwIk8p9zKRCpZ/akdEOg0=; b=SBeTInydNOQQSIIgk1UxdwVTQtS3JSVzhuVNVlrgcagFpZOPybBo34Ku5h1qMTiB2j yLrYCTaTVCE0Ehr69817fN2BPpvLK7YbwyCh5nhsWG840re0GlSaPKs+ehWPSDyCxj9I UrTfkkDECUOu/Yqo+yJU3C86mczmDpVax0KqMA7vYxuqSdsWEunc25DriW+PtKEWE1NR w3q49LFANdzUz9+7UyKl3TRAajeWnRVZBjAV/7djMAN/5fWwG/yFWrNvGGcWix7mqLuK 7aWYAjiKpbsyVlfSgl2c6wz7WsLkrns+jcvVw4aSzn4fhWYkPmkFLlAW8RSLVUNQ+eVc Jegw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=ldQA7TEIhVlvvX0NA61TMlZwIk8p9zKRCpZ/akdEOg0=; b=Wfo25yKrbRUqnr47SQfBhjGgqjtlFEslyVtKAfqtMb886UwJ4OLkrVs22j0JsTvX+V R6AzwqAnOSCaPhSrwSOifQpV67hTDN45Ug5JLbu/H601bEdHP8DD40Zp+wq6Z/zrqI8v H1zgYCFU37VcP66f2TMAMlVxUriDpwZzSfYCrTNdJvXFGDGlWrXRA4Pq0tE0x/aELDMY vlGRdU9BhlfjTDPd5+VHUsIKPJclyNusdEm/qz1P+iMg5tYIuyx1pYHY4+91taNVWZ7e VtlifBFefgr2irng2CBBdAdZrGfoqt41ZbgX8PUt0QAZMChFNsCqEuoudmGqpqEM/6lJ MZ+g== X-Gm-Message-State: AJIora/gqELYyFpXyueC1HXiMcR0X24vmw1pG+co6x1F/6tp21IRYcGJ HV4PoUO0pVe9M8r4nVr1wBUe6BRuC/FkoNyChV8= X-Google-Smtp-Source: AGRyM1veGI4lauYAj+Jx+KdPs9qNmtQBNqTmD2jU3DLVNe6adv7B8kGGWq6eSm1+9suo0J0EgRfBE0SI0CWHhai2OBg= X-Received: from samitolvanen.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:4f92]) (user=samitolvanen job=sendgmr) by 2002:a17:902:aa96:b0:168:c298:bdf3 with SMTP id d22-20020a170902aa9600b00168c298bdf3mr6054843plr.100.1655409483545; Thu, 16 Jun 2022 12:58:03 -0700 (PDT) Date: Thu, 16 Jun 2022 19:57:59 +0000 Message-Id: <20220616195759.3214538-1-samitolvanen@google.com> Mime-Version: 1.0 X-Developer-Key: i=samitolvanen@google.com; a=openpgp; fpr=35CCFB63B283D6D3AEB783944CB5F6848BBC56EE X-Developer-Signature: v=1; a=openpgp-sha256; l=968; h=from:subject; bh=M/Cou+QZRQKMB4gLGeT+Xtn7Trwx0hGB9psUmLrjsNk=; b=owEB7QES/pANAwAKAUy19oSLvFbuAcsmYgBiq4tH6ZJW4TbEAX23BMBRV4z4mmz7N4T+HenbeDBu YMsr6PSJAbMEAAEKAB0WIQQ1zPtjsoPW0663g5RMtfaEi7xW7gUCYquLRwAKCRBMtfaEi7xW7rgKC/ 4lpQ0qGDMRm/ABDcJQMZqJ3uw7lXDi2emAthJndiAaf9xGk9GrChQzgE79cFEfeQJF5RPv43L4FFgA nqPEc8B+odVxFoYYNefK/nesp2lFcXGL/zdR1xUCjfihCkOF1Fx5nKjTd0mz2pWzTF8YENjyEMWOOb X4Mhvo2HNIjMC0xG1E4A9nyB9RTJKzf13P59C5T6ywkIf0s7PgGSkEf/pe36rbVVLgQnnxwOKE5XGj U5gecLD22zQj6/dZehEmZS3YzjTtZiFRyaxk7QeenadkTB4YJ8UkWwXaqYO+aw4FJZx9V/+Hmrpvl2 57XF024/ew2WF233vSpMlRNfsZ+52HJkFrPSdTCgO41uoG5FsE8Ue0vqsPext7WCnOGk1POWvqhkFi svwtNGQfSFLTz0BcWhfI3183MwvXuAeFoR6BxJZCb5oCi8B4rfOz4q6eX1jirJ3hNs5BTHTZstxhH9 EiQrHULeVXIa695f8HSBI9zEGGkJRVQ5SjRH6Yr7YLerM= X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH] kbuild: Ignore __this_module in gen_autoksyms.sh From: Sami Tolvanen To: Masahiro Yamada Cc: Nicolas Schier , Alexander Lobakin , Nick Desaulniers , Steve Muckle , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Sami Tolvanen Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org Module object files can contain an undefined reference to __this_module, which isn't resolved until we link the final .ko. The kernel doesn't export this symbol, so ignore it in gen_autoksyms.sh. This avoids an unnecessary vmlinux rebuild with UNUSED_KSYMS_WHITELIST when we have a symbol list that already contains all the module dependencies. Signed-off-by: Sami Tolvanen Tested-by: Steve Muckle Reviewed-by: Nick Desaulniers Tested-by: Ramji Jiyani --- scripts/gen_autoksyms.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/gen_autoksyms.sh b/scripts/gen_autoksyms.sh index faacf7062122..653fadbad302 100755 --- a/scripts/gen_autoksyms.sh +++ b/scripts/gen_autoksyms.sh @@ -56,4 +56,7 @@ EOT # point addresses. sed -e 's/^\.//' | sort -u | +# Ignore __this_module. It's not an exported symbol, and will be resolved +# when the final .ko's are linked. +grep -v '^__this_module$' | sed -e 's/\(.*\)/#define __KSYM_\1 1/' >> "$output_file"