| Message ID | 20220619170337.24743-1-sangyu.code@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Documentation: kbuild: fix typo in kconfig-language.rst | expand |
On 6/19/22 10:03, SangYuhiter wrote: > change "default y/m" to "default y/n" > add " should be "default y" " in default section d) > > Signed-off-by: SangYuhiter <sangyu.code@gmail.com> > --- > Documentation/kbuild/kconfig-language.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/kbuild/kconfig-language.rst b/Documentation/kbuild/kconfig-language.rst > index a7173843a294..ae3add11d5e7 100644 > --- a/Documentation/kbuild/kconfig-language.rst > +++ b/Documentation/kbuild/kconfig-language.rst > @@ -92,7 +92,7 @@ applicable everywhere (see syntax). > release to release. > > Note: > - Things that merit "default y/m" include: > + Things that merit "default y/n" include: "y/m" is correct here, so NAK. > > a) A new Kconfig option for something that used to always be built > should be "default y". > @@ -105,7 +105,7 @@ applicable everywhere (see syntax). > "default n". This allows you to provide sane defaults. > > d) Hardware or infrastructure that everybody expects, such as CONFIG_NET > - or CONFIG_BLOCK. These are rare exceptions. > + or CONFIG_BLOCK, should be "default y". These are rare exceptions. > > - type definition + default value:: >
On Mon, Jun 20, 2022 at 01:03:37AM +0800, SangYuhiter wrote: > Note: > - Things that merit "default y/m" include: > + Things that merit "default y/n" include: This is incorrect. it's Y(es) or M(odule).
diff --git a/Documentation/kbuild/kconfig-language.rst b/Documentation/kbuild/kconfig-language.rst index a7173843a294..ae3add11d5e7 100644 --- a/Documentation/kbuild/kconfig-language.rst +++ b/Documentation/kbuild/kconfig-language.rst @@ -92,7 +92,7 @@ applicable everywhere (see syntax). release to release. Note: - Things that merit "default y/m" include: + Things that merit "default y/n" include: a) A new Kconfig option for something that used to always be built should be "default y". @@ -105,7 +105,7 @@ applicable everywhere (see syntax). "default n". This allows you to provide sane defaults. d) Hardware or infrastructure that everybody expects, such as CONFIG_NET - or CONFIG_BLOCK. These are rare exceptions. + or CONFIG_BLOCK, should be "default y". These are rare exceptions. - type definition + default value::
change "default y/m" to "default y/n" add " should be "default y" " in default section d) Signed-off-by: SangYuhiter <sangyu.code@gmail.com> --- Documentation/kbuild/kconfig-language.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)