| Message ID | 20220906134801.4079497-2-nipun.gupta@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RFC,v3,1/7] dt-bindings: bus: add CDX bus device tree bindings | expand |
On Tue, 06 Sep 2022 19:17:55 +0530, Nipun Gupta wrote: > This patch adds a devicetree binding documentation for CDX > bus. > > CDX bus controller dynamically detects CDX bus and the > devices on these bus using CDX firmware. > > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com> > --- > .../devicetree/bindings/bus/xlnx,cdx.yaml | 75 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 81 insertions(+) > create mode 100644 Documentation/devicetree/bindings/bus/xlnx,cdx.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:18.23-21.11: Warning (unit_address_vs_reg): /example-0/smmu@ec000000: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:23.22-30.11: Warning (unit_address_vs_reg): /example-0/gic@e2000000: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:26.35-29.15: Warning (unit_address_vs_reg): /example-0/gic@e2000000/gic-its@e2040000: node has a unit name, but no reg or ranges property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: smmu@ec000000: $nodename:0: 'smmu@ec000000' does not match '^iommu@[0-9a-f]*' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: smmu@ec000000: 'reg' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: gic@e2000000: $nodename:0: 'gic@e2000000' does not match '^interrupt-controller(@[0-9a-f,]+)*$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: gic@e2000000: '#interrupt-cells' is a dependency of 'interrupt-controller' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: gic@e2000000: 'reg' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: gic@e2000000: gic-its@e2040000: False schema does not allow {'compatible': ['arm,gic-v3-its'], 'msi-controller': True, 'phandle': [[1]]} From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: gic@e2000000: gic-its@e2040000: '#msi-cells' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: gic@e2000000: gic-its@e2040000: 'reg' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: gic@e2000000: 'oneOf' conditional failed, one must be fixed: 'interrupts' is a required property 'interrupts-extended' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: cdx@4000000: reg: [[0, 67108864], [0, 4096]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/xlnx,cdx.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
[AMD Official Use Only - General] > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Tuesday, September 6, 2022 11:17 PM > To: Gupta, Nipun <Nipun.Gupta@amd.com> > Cc: gregkh@linuxfoundation.org; eric.auger@redhat.com; > devicetree@vger.kernel.org; linux-kbuild@vger.kernel.org; > jeffrey.l.hugo@gmail.com; maz@kernel.org; Gupta, Puneet (DCG-ENG) > <puneet.gupta@amd.com>; Michael.Srba@seznam.cz; cohuck@redhat.com; > will@kernel.org; masahiroy@kernel.org; mchehab+huawei@kernel.org; > joro@8bytes.org; okaya@kernel.org; alex.williamson@redhat.com; > song.bao.hua@hisilicon.com; jgg@nvidia.com; mani@kernel.org; linux- > kernel@vger.kernel.org; robin.murphy@arm.com; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; rafael@kernel.org; f.fainelli@gmail.com; > jgg@ziepe.ca; kvm@vger.kernel.org; Agarwal, Nikhil > <nikhil.agarwal@amd.com>; Anand, Harpreet <harpreet.anand@amd.com>; > yishaih@nvidia.com; linux-arm-kernel@lists.infradead.org; git (AMD-Xilinx) > <git@amd.com>; saravanak@google.com; Radovanovic, Aleksandar > <aleksandar.radovanovic@amd.com>; Simek, Michal > <michal.simek@amd.com>; ndesaulniers@google.com > Subject: Re: [RFC PATCH v3 1/7] dt-bindings: bus: add CDX bus device tree > bindings > > [CAUTION: External Email] > > On Tue, 06 Sep 2022 19:17:55 +0530, Nipun Gupta wrote: > > This patch adds a devicetree binding documentation for CDX > > bus. > > > > CDX bus controller dynamically detects CDX bus and the > > devices on these bus using CDX firmware. > > > > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com> > > --- > > .../devicetree/bindings/bus/xlnx,cdx.yaml | 75 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 81 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/bus/xlnx,cdx.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:18.23-21.11: > Warning (unit_address_vs_reg): /example-0/smmu@ec000000: node has a unit > name, but no reg or ranges property > Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:23.22-30.11: > Warning (unit_address_vs_reg): /example-0/gic@e2000000: node has a unit > name, but no reg or ranges property > Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:26.35-29.15: > Warning (unit_address_vs_reg): /example-0/gic@e2000000/gic-its@e2040000: > node has a unit name, but no reg or ranges property > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: > smmu@ec000000: $nodename:0: 'smmu@ec000000' does not match > '^iommu@[0-9a-f]*' > From schema: /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: > smmu@ec000000: 'reg' is a required property > From schema: /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: > gic@e2000000: $nodename:0: 'gic@e2000000' does not match '^interrupt- > controller(@[0-9a-f,]+)*$' > From schema: /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/interrupt-controller/arm,gic- > v3.yaml > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: > gic@e2000000: '#interrupt-cells' is a dependency of 'interrupt-controller' > From schema: /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/interrupt-controller/arm,gic- > v3.yaml > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: > gic@e2000000: 'reg' is a required property > From schema: /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/interrupt-controller/arm,gic- > v3.yaml > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: > gic@e2000000: gic-its@e2040000: False schema does not allow {'compatible': > ['arm,gic-v3-its'], 'msi-controller': True, 'phandle': [[1]]} > From schema: /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/interrupt-controller/arm,gic- > v3.yaml > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: > gic@e2000000: gic-its@e2040000: '#msi-cells' is a required property > From schema: /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/interrupt-controller/arm,gic- > v3.yaml > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: > gic@e2000000: gic-its@e2040000: 'reg' is a required property > From schema: /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/interrupt-controller/arm,gic- > v3.yaml > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: > gic@e2000000: 'oneOf' conditional failed, one must be fixed: > 'interrupts' is a required property > 'interrupts-extended' is a required property > From schema: /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/interrupt-controller/arm,gic- > v3.yaml > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb: > cdx@4000000: reg: [[0, 67108864], [0, 4096]] is too long > From schema: /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/bus/xlnx,cdx.yaml > > doc reference errors (make refcheckdocs): > > See > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw > ork.ozlabs.org%2Fpatch%2F&data=05%7C01%7Cnipun.gupta%40amd.com > %7C47f53d11f4024ba765f408da902fc525%7C3dd8961fe4884e608e11a82d994e > 183d%7C0%7C0%7C637980832144301226%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 3000%7C%7C%7C&sdata=BXO1d2OWdCQ1lb%2BEDNiUvmfSPPfxfzJET%2B > uuAL9EdEY%3D&reserved=0 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. I did run make dt_binding_check, but did not see the issue. Will update the dtschema and fix this. Thanks, Nipun
On 07/09/2022 05:13, Gupta, Nipun wrote: >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit. > > I did run make dt_binding_check, but did not see the issue. > Will update the dtschema and fix this. Regardless whether you saw it or not, the example DTS is incorrect... Even if there are no errors, please do not add incorrect DTS. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/bus/xlnx,cdx.yaml b/Documentation/devicetree/bindings/bus/xlnx,cdx.yaml new file mode 100644 index 000000000000..0aa5599ada8e --- /dev/null +++ b/Documentation/devicetree/bindings/bus/xlnx,cdx.yaml @@ -0,0 +1,75 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/bus/xlnx,cdx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: AMD CDX bus controller + +description: | + CDX bus controller for AMD devices is implemented to dynamically + detect CDX bus and devices on these bus using the firmware. + The CDX bus manages multiple FPGA based hardware devices, which + can support network, crypto or any other specialized type of + devices. These FPGA based devices can be added/modified dynamically + on run-time. + + All devices on the CDX bus will have a unique streamid (for IOMMU) + and a unique device ID (for MSI) corresponding to a requestor ID + (one to one associated with the device). The streamid and deviceid + are used to configure SMMU and GIC-ITS respectively. + + iommu-map property is used to define the set of stream ids + corresponding to each device and the associated IOMMU. + + The MSI writes are accompanied by sideband data (Device ID). + The msi-map property is used to associate the devices with the + device ID as well as the associated ITS controller. + +maintainers: + - Nipun Gupta <nipun.gupta@amd.com> + - Nikhil Agarwal <nikhil.agarwal@amd.com> + +properties: + compatible: + const: xlnx,cdxbus-controller-1.0 + + reg: + maxItems: 1 + + iommu-map: true + + msi-map: true + +required: + - compatible + - reg + - iommu-map + - msi-map + +additionalProperties: false + +examples: + - | + smmu@ec000000 { + compatible = "arm,smmu-v3"; + #iommu-cells = <1>; + }; + + gic@e2000000 { + compatible = "arm,gic-v3"; + interrupt-controller; + its: gic-its@e2040000 { + compatible = "arm,gic-v3-its"; + msi-controller; + }; + }; + + cdx: cdx@4000000 { + compatible = "xlnx,cdxbus-controller-1.0"; + reg = <0x00000000 0x04000000 0 0x1000>; + /* define map for RIDs 250-259 */ + iommu-map = <250 &smmu 250 10>; + /* define msi map for RIDs 250-259 */ + msi-map = <250 &its 250 10>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 9d7f64dc0efe..f0598b3d731c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -934,6 +934,12 @@ S: Supported F: drivers/crypto/ccp/ F: include/linux/ccp.h +AMD CDX BUS DRIVER +M: Nipun Gupta <nipun.gupta@amd.com> +M: Nikhil Agarwal <nikhil.agarwal@amd.com> +S: Maintained +F: Documentation/devicetree/bindings/bus/xlnx,cdx.yaml + AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - SEV SUPPORT M: Brijesh Singh <brijesh.singh@amd.com> M: Tom Lendacky <thomas.lendacky@amd.com>
This patch adds a devicetree binding documentation for CDX bus. CDX bus controller dynamically detects CDX bus and the devices on these bus using CDX firmware. Signed-off-by: Nipun Gupta <nipun.gupta@amd.com> --- .../devicetree/bindings/bus/xlnx,cdx.yaml | 75 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 81 insertions(+) create mode 100644 Documentation/devicetree/bindings/bus/xlnx,cdx.yaml