| Message ID | 20220929181223.2502994-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "kbuild: Check if linker supports the -X option" | expand |
On Thu, Sep 29, 2022 at 11:13 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > This reverts commit d79a27195a33f4b5e591de5536799ad874ea6cf5. > > According to the commit description, this ld-option test was added for > the gold linker at that time. > > Commit 75959d44f9dc ("kbuild: Fail if gold linker is detected") gave > up the gold linker support after all. > > I tested the BFD linker from binutils 2.23 and LLD from LLVM 11.0.0. > Both of them support the -X option. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 49dcae886c48..d7c85ec79000 100644 > --- a/Makefile > +++ b/Makefile > @@ -1037,7 +1037,7 @@ KBUILD_LDFLAGS += $(call ld-option,--no-warn-rwx-segments) > endif > > ifeq ($(CONFIG_STRIP_ASM_SYMS),y) > -LDFLAGS_vmlinux += $(call ld-option, -X,) > +LDFLAGS_vmlinux += -X > endif > > ifeq ($(CONFIG_RELR),y) > -- > 2.34.1 >
On Fri, Sep 30, 2022 at 03:12:23AM +0900, Masahiro Yamada wrote: > This reverts commit d79a27195a33f4b5e591de5536799ad874ea6cf5. > > According to the commit description, this ld-option test was added for > the gold linker at that time. > > Commit 75959d44f9dc ("kbuild: Fail if gold linker is detected") gave > up the gold linker support after all. > > I tested the BFD linker from binutils 2.23 and LLD from LLVM 11.0.0. > Both of them support the -X option. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 49dcae886c48..d7c85ec79000 100644 > --- a/Makefile > +++ b/Makefile > @@ -1037,7 +1037,7 @@ KBUILD_LDFLAGS += $(call ld-option,--no-warn-rwx-segments) > endif > > ifeq ($(CONFIG_STRIP_ASM_SYMS),y) > -LDFLAGS_vmlinux += $(call ld-option, -X,) > +LDFLAGS_vmlinux += -X > endif > > ifeq ($(CONFIG_RELR),y) > -- > 2.34.1 >
diff --git a/Makefile b/Makefile index 49dcae886c48..d7c85ec79000 100644 --- a/Makefile +++ b/Makefile @@ -1037,7 +1037,7 @@ KBUILD_LDFLAGS += $(call ld-option,--no-warn-rwx-segments) endif ifeq ($(CONFIG_STRIP_ASM_SYMS),y) -LDFLAGS_vmlinux += $(call ld-option, -X,) +LDFLAGS_vmlinux += -X endif ifeq ($(CONFIG_RELR),y)
This reverts commit d79a27195a33f4b5e591de5536799ad874ea6cf5. According to the commit description, this ld-option test was added for the gold linker at that time. Commit 75959d44f9dc ("kbuild: Fail if gold linker is detected") gave up the gold linker support after all. I tested the BFD linker from binutils 2.23 and LLD from LLVM 11.0.0. Both of them support the -X option. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)