| Message ID | 20221001202836.3110985-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | docs: bump minimal GNU Make version to 3.82 | expand |
On Sat, Oct 1, 2022 at 10:30 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > The error message looks weird, but the reason is that the 'private' > keyword is only supported since GNU Make 3.82. Sorry about that. Indeed, it was added in 3.82 [1,2]. Given GCC 5.1 (the current minimum) was released 5 years later, I guess it is OK to increase it. Reviewed-by: Miguel Ojeda <ojeda@kernel.org> [1] https://git.savannah.gnu.org/cgit/make.git/commit/?id=5b4d419476e9fbda8ea26017f6ec15956d103ed9 [2] https://git.savannah.gnu.org/cgit/make.git/tree/ChangeLog?h=3.82#n814 Cheers, Miguel
On Mon, Oct 3, 2022 at 4:22 AM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > On Sat, Oct 1, 2022 at 10:30 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > > > The error message looks weird, but the reason is that the 'private' > > keyword is only supported since GNU Make 3.82. > > Sorry about that. Indeed, it was added in 3.82 [1,2]. Given GCC 5.1 > (the current minimum) was released 5 years later, I guess it is OK to > increase it. > > Reviewed-by: Miguel Ojeda <ojeda@kernel.org> > > [1] https://git.savannah.gnu.org/cgit/make.git/commit/?id=5b4d419476e9fbda8ea26017f6ec15956d103ed9 > [2] https://git.savannah.gnu.org/cgit/make.git/tree/ChangeLog?h=3.82#n814 > > Cheers, > Miguel Applied to linux-kbuild.
diff --git a/Documentation/process/changes.rst b/Documentation/process/changes.rst index 19c286c23786..26a7fd875cfa 100644 --- a/Documentation/process/changes.rst +++ b/Documentation/process/changes.rst @@ -31,7 +31,7 @@ you probably needn't concern yourself with pcmciautils. ====================== =============== ======================================== GNU C 5.1 gcc --version Clang/LLVM (optional) 11.0.0 clang --version -GNU make 3.81 make --version +GNU make 3.82 make --version bash 4.2 bash --version binutils 2.23 ld -v flex 2.5.35 flex --version @@ -83,7 +83,7 @@ docs on :ref:`Building Linux with Clang/LLVM <kbuild_llvm>`. Make ---- -You will need GNU make 3.81 or later to build the kernel. +You will need GNU make 3.82 or later to build the kernel. Bash ----
GNU Make 3.81 fails in CONFIG_RUST=y builds. rust/Makefile:105: *** multiple target patterns. Stop. make[1]: *** [prepare] Error 2 make: *** [__sub-make] Error 2 The error message looks weird, but the reason is that the 'private' keyword is only supported since GNU Make 3.82. GNU Make 3.81 is still able to build the kernel if CONFIG_RUST is disabled, but it might be a good timing to bump the minimal GNU Make version. Perhaps, I am the last person who was testing GNU Make 3.81. GNU Make 3.81 was released in 2006, GNU Make 3.82 in 2010. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- Documentation/process/changes.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)