diff mbox series

kbuild: fix single directory build

Message ID 20221014201811.1118103-1-masahiroy@kernel.org (mailing list archive)
State New, archived
Headers show
Series kbuild: fix single directory build | expand

Commit Message

Masahiro Yamada Oct. 14, 2022, 8:18 p.m. UTC 
Commit f110e5a250e3 ("kbuild: refactor single builds of *.ko") was wrong.

KBUILD_MODULES _is_ needed for single builds.

Otherwise, "make foo/bar/baz/" does not build module objects at all.

Fixes: f110e5a250e3 ("kbuild: refactor single builds of *.ko")
Reported-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

David Sterba Oct. 14, 2022, 9:18 p.m. UTC | #1 
On Sat, Oct 15, 2022 at 05:18:11AM +0900, Masahiro Yamada wrote:
> Commit f110e5a250e3 ("kbuild: refactor single builds of *.ko") was wrong.
> 
> KBUILD_MODULES _is_ needed for single builds.
> 
> Otherwise, "make foo/bar/baz/" does not build module objects at all.
> 
> Fixes: f110e5a250e3 ("kbuild: refactor single builds of *.ko")
> Reported-by: David Sterba <dsterba@suse.cz>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Now it works, thanks.

Tested-by: David Sterba <dsterba@suse.com>
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 85a63a1d29b3..48a005fc69ca 100644
--- a/Makefile
+++ b/Makefile
@@ -1978,6 +1978,8 @@  endif
 
 single-goals := $(addprefix $(build-dir)/, $(single-no-ko))
 
+KBUILD_MODULES := 1
+
 endif
 
 # Preset locale variables to speed up the build process. Limit locale