| Message ID | 20221110113034.17563-1-jakub@cloudflare.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fault-inject: Enable stacktrace filter for x86-64 | expand |
2022年11月10日(木) 20:30 Jakub Sitnicki <jakub@cloudflare.com>: > > Stacktrace filtering for fault injection has been disabled on x86-64 since > 2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault > injection: disable stacktrace filter for x86-64"). > > In 2017, the ORC unwider, an alternative to DWARF unwinder has been added > in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder"). > > We can now re-enable the stacktrace filter for x86-64. The same change by Wei Yongjun is already in the linux-next via -mm tree. But thank you for the good explanation.
On Sat, Nov 12, 2022 at 01:41 AM +09, Akinobu Mita wrote: > 2022年11月10日(木) 20:30 Jakub Sitnicki <jakub@cloudflare.com>: >> >> Stacktrace filtering for fault injection has been disabled on x86-64 since >> 2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault >> injection: disable stacktrace filter for x86-64"). >> >> In 2017, the ORC unwider, an alternative to DWARF unwinder has been added >> in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder"). >> >> We can now re-enable the stacktrace filter for x86-64. > > The same change by Wei Yongjun is already in the linux-next via -mm tree. > > But thank you for the good explanation. Thanks for letting me know. Will check linux-next next time. Please ignore my patch. Sorry for the noise.
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 3fc7abffc7aa..32c5329b0dd9 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1963,7 +1963,6 @@ config FAIL_SUNRPC config FAULT_INJECTION_STACKTRACE_FILTER bool "stacktrace filter for fault-injection capabilities" depends on FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT - depends on !X86_64 select STACKTRACE depends on FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86 help
Stacktrace filtering for fault injection has been disabled on x86-64 since 2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault injection: disable stacktrace filter for x86-64"). In 2017, the ORC unwider, an alternative to DWARF unwinder has been added in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder"). We can now re-enable the stacktrace filter for x86-64. Cc: linux-kbuild@vger.kernel.org Cc: x86@kernel.org Cc: Akinobu Mita <akinobu.mita@gmail.com> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com> --- lib/Kconfig.debug | 1 - 1 file changed, 1 deletion(-)