| Message ID | 20221228-drop-qunused-arguments-v1-10-658cbc8fc592@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS | expand |
Nathan Chancellor <nathan@kernel.org> writes: > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > points out that there is a linking phase flag added to CFLAGS, which > will only be used for compiling > > clang-16: error: argument unused during compilation: '-shared' [-Werror,-Wunused-command-line-argument] > > '-shared' is already present in ldflags-y so it can just be dropped. > > Fixes: 2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) to link vDSO") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Sven Schnelle <svens@linux.ibm.com>
diff --git a/arch/s390/kernel/vdso64/Makefile b/arch/s390/kernel/vdso64/Makefile index a2fe9383d452..34f9542636e9 100644 --- a/arch/s390/kernel/vdso64/Makefile +++ b/arch/s390/kernel/vdso64/Makefile @@ -25,7 +25,7 @@ KBUILD_AFLAGS_64 := $(filter-out -m64,$(KBUILD_AFLAGS)) KBUILD_AFLAGS_64 += -m64 KBUILD_CFLAGS_64 := $(filter-out -m64,$(KBUILD_CFLAGS)) -KBUILD_CFLAGS_64 += -m64 -fPIC -shared -fno-common -fno-builtin +KBUILD_CFLAGS_64 += -m64 -fPIC -fno-common -fno-builtin ldflags-y := -fPIC -shared -soname=linux-vdso64.so.1 \ --hash-style=both --build-id=sha1 -T
When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it points out that there is a linking phase flag added to CFLAGS, which will only be used for compiling clang-16: error: argument unused during compilation: '-shared' [-Werror,-Wunused-command-line-argument] '-shared' is already present in ldflags-y so it can just be dropped. Fixes: 2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) to link vDSO") Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- Cc: hca@linux.ibm.com Cc: gor@linux.ibm.com Cc: agordeev@linux.ibm.com Cc: borntraeger@linux.ibm.com Cc: svens@linux.ibm.com Cc: linux-s390@vger.kernel.org --- arch/s390/kernel/vdso64/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)