| Message ID | 20221228-drop-qunused-arguments-v1-13-658cbc8fc592@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS | expand |
On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor <nathan@kernel.org> wrote: > > Currently, these warnings are hidden with -Qunused-arguments in > KBUILD_CPPFLAGS. Once that option is removed, these warnings should be > turned into hard errors to make unconditionally added but unsupported > flags for the current compilation mode or target obvious due to a failed > build; otherwise, the warnings might just be ignored if the build log is > not checked. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1587 > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > scripts/Makefile.clang | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/Makefile.clang b/scripts/Makefile.clang > index 87285b76adb2..70b354fa1cb4 100644 > --- a/scripts/Makefile.clang > +++ b/scripts/Makefile.clang > @@ -36,6 +36,8 @@ endif > # so they can be implemented or wrapped in cc-option. > CLANG_FLAGS += -Werror=unknown-warning-option > CLANG_FLAGS += -Werror=ignored-optimization-argument > +CLANG_FLAGS += -Werror=option-ignored > +CLANG_FLAGS += -Werror=unused-command-line-argument > KBUILD_CFLAGS += $(CLANG_FLAGS) > KBUILD_AFLAGS += $(CLANG_FLAGS) > export CLANG_FLAGS > > -- > 2.39.0 >
diff --git a/scripts/Makefile.clang b/scripts/Makefile.clang index 87285b76adb2..70b354fa1cb4 100644 --- a/scripts/Makefile.clang +++ b/scripts/Makefile.clang @@ -36,6 +36,8 @@ endif # so they can be implemented or wrapped in cc-option. CLANG_FLAGS += -Werror=unknown-warning-option CLANG_FLAGS += -Werror=ignored-optimization-argument +CLANG_FLAGS += -Werror=option-ignored +CLANG_FLAGS += -Werror=unused-command-line-argument KBUILD_CFLAGS += $(CLANG_FLAGS) KBUILD_AFLAGS += $(CLANG_FLAGS) export CLANG_FLAGS
Currently, these warnings are hidden with -Qunused-arguments in KBUILD_CPPFLAGS. Once that option is removed, these warnings should be turned into hard errors to make unconditionally added but unsupported flags for the current compilation mode or target obvious due to a failed build; otherwise, the warnings might just be ignored if the build log is not checked. Link: https://github.com/ClangBuiltLinux/linux/issues/1587 Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- scripts/Makefile.clang | 2 ++ 1 file changed, 2 insertions(+)