| Message ID | 20230203173704.108942-1-mcanal@igalia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | rust: delete rust-project.json when running make clean | expand |
On Fri, Feb 3, 2023 at 6:37 PM Maíra Canal <mcanal@igalia.com> wrote: > > rust-project.json is the configuration file used by rust-analyzer. > As it is a configuration file and it is not needed to build external > modules, it should be delete by make clean. So, delete rust-project.json > when running make clean. > > Link: https://github.com/Rust-for-Linux/linux/issues/939 Thanks Maíra! I will add a tag with Björn as a `Suggested-by`, if he is OK with that. Cheers, Miguel
On Friday, February 3rd, 2023 at 21:08, Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > On Fri, Feb 3, 2023 at 6:37 PM Maíra Canal mcanal@igalia.com wrote: > > > rust-project.json is the configuration file used by rust-analyzer. > > As it is a configuration file and it is not needed to build external > > modules, it should be delete by make clean. So, delete rust-project.json > > when running make clean. > > > > Link: https://github.com/Rust-for-Linux/linux/issues/939 > > > Thanks Maíra! I will add a tag with Björn as a `Suggested-by`, if he > is OK with that. > > Cheers, > Miguel Sure
On 3 Feb 2023, at 18:37, Maíra Canal wrote: > rust-project.json is the configuration file used by rust-analyzer. > As it is a configuration file and it is not needed to build external > modules, it should be delete by make clean. So, delete rust-project.json > when running make clean. > > Link: https://github.com/Rust-for-Linux/linux/issues/939 > Signed-off-by: Maíra Canal <mcanal@igalia.com> Reviewed-by: Finn Behrens <fin@nyantec.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index f41ec8c8426b..6223d5f82f66 100644 > --- a/Makefile > +++ b/Makefile > @@ -1573,7 +1573,7 @@ endif # CONFIG_MODULES > CLEAN_FILES += include/ksym vmlinux.symvers modules-only.symvers \ > modules.builtin modules.builtin.modinfo modules.nsdeps \ > compile_commands.json .thinlto-cache rust/test rust/doc \ > - .vmlinux.objs .vmlinux.export.c > + rust-project.json .vmlinux.objs .vmlinux.export.c > > # Directories & files removed with 'make mrproper' > MRPROPER_FILES += include/config include/generated \ > -- > 2.39.1
On Sat, Feb 4, 2023 at 5:08 AM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > On Fri, Feb 3, 2023 at 6:37 PM Maíra Canal <mcanal@igalia.com> wrote: > > > > rust-project.json is the configuration file used by rust-analyzer. > > As it is a configuration file and it is not needed to build external > > modules, it should be delete by make clean. So, delete rust-project.json > > when running make clean. > > > > Link: https://github.com/Rust-for-Linux/linux/issues/939 > > Thanks Maíra! I will add a tag with Björn as a `Suggested-by`, if he > is OK with that. > > Cheers, > Miguel Miguel, Are you applying this to your tree, or do you want me to pick this up? For the former case, Acked-by: Masahiro Yamada <masahiroy@kernel.org>
On Sat, Feb 4, 2023 at 6:59 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > Miguel, > > Are you applying this to your tree, > or do you want me to pick this up? > > For the former case, > > Acked-by: Masahiro Yamada <masahiroy@kernel.org> Thanks! I was about to apply it, but let me know if you prefer otherwise. Cheers, Miguel
On Sun, Feb 5, 2023 at 3:04 AM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > On Sat, Feb 4, 2023 at 6:59 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > > > Miguel, > > > > Are you applying this to your tree, > > or do you want me to pick this up? > > > > For the former case, > > > > Acked-by: Masahiro Yamada <masahiroy@kernel.org> > > Thanks! I was about to apply it, but let me know if you prefer otherwise. > > Cheers, > Miguel Please go ahead.
On Fri Feb 3, 2023 at 6:37 PM CET, Maíra Canal wrote: > rust-project.json is the configuration file used by rust-analyzer. > As it is a configuration file and it is not needed to build external > modules, it should be delete by make clean. So, delete rust-project.json > when running make clean. > > Link: https://github.com/Rust-for-Linux/linux/issues/939 > Signed-off-by: Maíra Canal <mcanal@igalia.com> > --- Reviewd-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index f41ec8c8426b..6223d5f82f66 100644 > --- a/Makefile > +++ b/Makefile > @@ -1573,7 +1573,7 @@ endif # CONFIG_MODULES > CLEAN_FILES += include/ksym vmlinux.symvers modules-only.symvers \ > modules.builtin modules.builtin.modinfo modules.nsdeps \ > compile_commands.json .thinlto-cache rust/test rust/doc \ > - .vmlinux.objs .vmlinux.export.c > + rust-project.json .vmlinux.objs .vmlinux.export.c > > # Directories & files removed with 'make mrproper' > MRPROPER_FILES += include/config include/generated \ > -- > 2.39.1
On Fri, Feb 3, 2023 at 6:37 PM Maíra Canal <mcanal@igalia.com> wrote: > > rust-project.json is the configuration file used by rust-analyzer. > As it is a configuration file and it is not needed to build external > modules, it should be delete by make clean. So, delete rust-project.json > when running make clean. Applied to `rust-next`, thanks! Cheers, Miguel
diff --git a/Makefile b/Makefile index f41ec8c8426b..6223d5f82f66 100644 --- a/Makefile +++ b/Makefile @@ -1573,7 +1573,7 @@ endif # CONFIG_MODULES CLEAN_FILES += include/ksym vmlinux.symvers modules-only.symvers \ modules.builtin modules.builtin.modinfo modules.nsdeps \ compile_commands.json .thinlto-cache rust/test rust/doc \ - .vmlinux.objs .vmlinux.export.c + rust-project.json .vmlinux.objs .vmlinux.export.c # Directories & files removed with 'make mrproper' MRPROPER_FILES += include/config include/generated \
rust-project.json is the configuration file used by rust-analyzer. As it is a configuration file and it is not needed to build external modules, it should be delete by make clean. So, delete rust-project.json when running make clean. Link: https://github.com/Rust-for-Linux/linux/issues/939 Signed-off-by: Maíra Canal <mcanal@igalia.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)