From patchwork Fri Jul 28 11:34:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 13331739 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5759CC00528 for ; Fri, 28 Jul 2023 11:34:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234904AbjG1Lei (ORCPT ); Fri, 28 Jul 2023 07:34:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236217AbjG1Lea (ORCPT ); Fri, 28 Jul 2023 07:34:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBE7530F5; Fri, 28 Jul 2023 04:34:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 879FB6211A; Fri, 28 Jul 2023 11:34:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AB64C433C9; Fri, 28 Jul 2023 11:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690544069; bh=ARjM/rczxk3PX8PtoECoSFwHH4d2kchH7iqw5zHKaMc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aGRjKZctgpAez9JyZmIp+7xnTxyWs4j6DoLupOz05gTnl75i0k1/pPgpFP6fUQCe/ CQNmYenJ+QmcFLI5n0FpyE4LK9N2UqpxQMLk/UNLnWTVsdYUVzgt0afS/jh0gLykF6 FFenPhN+Ejypv937A0khJmKuj90SGLInsJgo53a3vtLAwtwlnrtl8Z1yzEStb5hW0B jKxrCPoTPXakpnPMbgrjkCzz9+656tB6SW63BjY6FUyiL58NnKOiJ3JWy1SnTt9pN1 hNn4LNpoyHm8sGQbue4fkkKPFKU6iBV1SgJsMbZp03dfVc1/wCfNLyK462Rji9GF+p Qa9mPD9i2uhLA== From: Will Deacon To: linux-kernel@vger.kernel.org Cc: kernel-team@android.com, Will Deacon , Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Josh Poimboeuf , John Stultz , linux-kbuild@vger.kernel.org Subject: [PATCH v3 3/4] scripts/faddr2line: Constrain readelf output to symbols from System.map Date: Fri, 28 Jul 2023 12:34:14 +0100 Message-Id: <20230728113415.21067-4-will@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230728113415.21067-1-will@kernel.org> References: <20230728113415.21067-1-will@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org Some symbols emitted in the readelf output but filtered from System.map can confuse the 'faddr2line' symbol size calculation, resulting in the erroneous rejection of valid offsets. This is especially prevalent when building an arm64 kernel with CONFIG_CFI_CLANG=y, where most functions are prefixed with a 32-bit data value in a '$d.n' section. For example: 447538: ffff800080014b80 548 FUNC GLOBAL DEFAULT 2 do_one_initcall 104: ffff800080014c74 0 NOTYPE LOCAL DEFAULT 2 $x.73 106: ffff800080014d30 0 NOTYPE LOCAL DEFAULT 2 $x.75 111: ffff800080014da4 0 NOTYPE LOCAL DEFAULT 2 $d.78 112: ffff800080014da8 0 NOTYPE LOCAL DEFAULT 2 $x.79 36: ffff800080014de0 200 FUNC LOCAL DEFAULT 2 run_init_process Adding a warning to do_one_initcall() results in: | WARNING: CPU: 0 PID: 1 at init/main.c:1236 do_one_initcall+0xf4/0x260 Which 'faddr2line' refuses to accept: $ ./scripts/faddr2line vmlinux do_one_initcall+0xf4/0x260 skipping do_one_initcall address at 0xffff800080014c74 due to size mismatch (0x260 != 0x224) no match for do_one_initcall+0xf4/0x260 Filter out entries from readelf using the 'sysmap-ignored-syms.sed' script used to construct System.map, so that the size of a symbol is calculated as a delta to the next symbol present in ksymtab. Cc: Josh Poimboeuf Cc: John Stultz Signed-off-by: Will Deacon --- scripts/faddr2line | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/faddr2line b/scripts/faddr2line index 62a3fa6f6f59..da734af90036 100755 --- a/scripts/faddr2line +++ b/scripts/faddr2line @@ -64,6 +64,7 @@ else UTIL_PREFIX=${CROSS_COMPILE:-} fi +IGNORED_SYMS=$(dirname $0)/sysmap-ignored-syms.sed READELF="${UTIL_PREFIX}readelf" ADDR2LINE="${UTIL_PREFIX}addr2line" AWK="awk" @@ -185,7 +186,7 @@ __faddr2line() { found=2 break fi - done < <(${READELF} --symbols --wide $objfile | sed 's/\[.*\]//' | ${AWK} -v sec=$sym_sec '$7 == sec' | sort --key=2) + done < <(${READELF} --symbols --wide $objfile | sed -f ${IGNORED_SYMS} -e 's/\[.*\]//' | ${AWK} -v sec=$sym_sec '$7 == sec' | sort --key=2) if [[ $found = 0 ]]; then warn "can't find symbol: sym_name: $sym_name sym_sec: $sym_sec sym_addr: $sym_addr sym_elf_size: $sym_elf_size"