| Message ID | 20230805034256.2478162-1-Mr.Bossman075@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v1] kconfig: Alias mconfig to menuconfig, qconfig to xconfig | expand |
Hi, On 8/4/23 20:42, Jesse Taube wrote: > All the other menu-based config tools have a one-letter prefix, and > are named the same as their respective file, > except for mconfig and qconfig. This commit adds an alias for mconfig > to menuconfig and qconfig to xconfig. > > Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com> > --- > scripts/kconfig/Makefile | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > index af1c96198f49..319cd623acb9 100644 > --- a/scripts/kconfig/Makefile > +++ b/scripts/kconfig/Makefile > @@ -45,7 +47,7 @@ PHONY += build_$(1) > build_$(1): $(obj)/$($(1)-prog) > endef > > -$(foreach c, config menuconfig nconfig gconfig xconfig, $(eval $(call config_rule,$(c)))) > +$(foreach c, config menuconfig mconfig nconfig gconfig xconfig qconfig, $(eval $(call config_rule,$(c)))) > > PHONY += localmodconfig localyesconfig > localyesconfig localmodconfig: $(obj)/conf > @@ -118,7 +120,9 @@ help: > @echo ' config - Update current config utilising a line-oriented program' > @echo ' nconfig - Update current config utilising a ncurses menu based program' > @echo ' menuconfig - Update current config utilising a menu based program' > + @echo ' mconfig - Alias to menuconfig' > @echo ' xconfig - Update current config utilising a Qt based front-end' > + @echo ' qconfig - Alias to xconfig Seems to be missing an ending ' mark above... if we need this. > @echo ' gconfig - Update current config utilising a GTK+ based front-end' > @echo ' oldconfig - Update current config utilising a provided .config as base' > @echo ' localmodconfig - Update current config disabling modules not loaded'
On Fri, Aug 4, 2023 at 11:54 PM Randy Dunlap <rdunlap@infradead.org> wrote: > > Hi, > > On 8/4/23 20:42, Jesse Taube wrote: > > All the other menu-based config tools have a one-letter prefix, and > > are named the same as their respective file, > > except for mconfig and qconfig. This commit adds an alias for mconfig > > to menuconfig and qconfig to xconfig. > > > > Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com> > > --- > > scripts/kconfig/Makefile | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > > index af1c96198f49..319cd623acb9 100644 > > --- a/scripts/kconfig/Makefile > > +++ b/scripts/kconfig/Makefile > > > @@ -45,7 +47,7 @@ PHONY += build_$(1) > > build_$(1): $(obj)/$($(1)-prog) > > endef > > > > -$(foreach c, config menuconfig nconfig gconfig xconfig, $(eval $(call config_rule,$(c)))) > > +$(foreach c, config menuconfig mconfig nconfig gconfig xconfig qconfig, $(eval $(call config_rule,$(c)))) > > > > PHONY += localmodconfig localyesconfig > > localyesconfig localmodconfig: $(obj)/conf > > @@ -118,7 +120,9 @@ help: > > @echo ' config - Update current config utilising a line-oriented program' > > @echo ' nconfig - Update current config utilising a ncurses menu based program' > > @echo ' menuconfig - Update current config utilising a menu based program' > > + @echo ' mconfig - Alias to menuconfig' > > @echo ' xconfig - Update current config utilising a Qt based front-end' > > + @echo ' qconfig - Alias to xconfig' Crap how did I miss this. @Masahiro, can you add that when applying? I'll take a reviewed-by as a yes otherwise I will submit V2 tomorrow. > > Seems to be missing an ending ' mark above... if we need this. > > > @echo ' gconfig - Update current config utilising a GTK+ based front-end' > > @echo ' oldconfig - Update current config utilising a provided .config as base' > > @echo ' localmodconfig - Update current config disabling modules not loaded' > > -- > ~Randy
On Sat, Aug 5, 2023 at 1:38 PM Jesse T <mr.bossman075@gmail.com> wrote: > > On Fri, Aug 4, 2023 at 11:54 PM Randy Dunlap <rdunlap@infradead.org> wrote: > > > > Hi, > > > > On 8/4/23 20:42, Jesse Taube wrote: > > > All the other menu-based config tools have a one-letter prefix, and > > > are named the same as their respective file, > > > except for mconfig and qconfig. This commit adds an alias for mconfig > > > to menuconfig and qconfig to xconfig. > > > > > > Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com> > > > --- > > > scripts/kconfig/Makefile | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > > > index af1c96198f49..319cd623acb9 100644 > > > --- a/scripts/kconfig/Makefile > > > +++ b/scripts/kconfig/Makefile > > > > > @@ -45,7 +47,7 @@ PHONY += build_$(1) > > > build_$(1): $(obj)/$($(1)-prog) > > > endef > > > > > > -$(foreach c, config menuconfig nconfig gconfig xconfig, $(eval $(call config_rule,$(c)))) > > > +$(foreach c, config menuconfig mconfig nconfig gconfig xconfig qconfig, $(eval $(call config_rule,$(c)))) > > > > > > PHONY += localmodconfig localyesconfig > > > localyesconfig localmodconfig: $(obj)/conf > > > @@ -118,7 +120,9 @@ help: > > > @echo ' config - Update current config utilising a line-oriented program' > > > @echo ' nconfig - Update current config utilising a ncurses menu based program' > > > @echo ' menuconfig - Update current config utilising a menu based program' > > > + @echo ' mconfig - Alias to menuconfig' > > > @echo ' xconfig - Update current config utilising a Qt based front-end' > > > + @echo ' qconfig - Alias to xconfig' > > Crap how did I miss this. > @Masahiro, can you add that when applying? I am not applying this. I do not understand why it is useful. > I'll take a reviewed-by as a yes otherwise I will submit V2 tomorrow. > > > > > Seems to be missing an ending ' mark above... if we need this. > > > > > @echo ' gconfig - Update current config utilising a GTK+ based front-end' > > > @echo ' oldconfig - Update current config utilising a provided .config as base' > > > @echo ' localmodconfig - Update current config disabling modules not loaded' > > > > -- > > ~Randy -- Best Regards Masahiro Yamada
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index af1c96198f49..319cd623acb9 100644 --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Makefile @@ -32,9 +32,11 @@ unexport CONFIG_ config-prog := conf menuconfig-prog := mconf +mconfig-prog := mconf nconfig-prog := nconf gconfig-prog := gconf xconfig-prog := qconf +qconfig-prog := qconf define config_rule PHONY += $(1) @@ -45,7 +47,7 @@ PHONY += build_$(1) build_$(1): $(obj)/$($(1)-prog) endef -$(foreach c, config menuconfig nconfig gconfig xconfig, $(eval $(call config_rule,$(c)))) +$(foreach c, config menuconfig mconfig nconfig gconfig xconfig qconfig, $(eval $(call config_rule,$(c)))) PHONY += localmodconfig localyesconfig localyesconfig localmodconfig: $(obj)/conf @@ -118,7 +120,9 @@ help: @echo ' config - Update current config utilising a line-oriented program' @echo ' nconfig - Update current config utilising a ncurses menu based program' @echo ' menuconfig - Update current config utilising a menu based program' + @echo ' mconfig - Alias to menuconfig' @echo ' xconfig - Update current config utilising a Qt based front-end' + @echo ' qconfig - Alias to xconfig @echo ' gconfig - Update current config utilising a GTK+ based front-end' @echo ' oldconfig - Update current config utilising a provided .config as base' @echo ' localmodconfig - Update current config disabling modules not loaded'
All the other menu-based config tools have a one-letter prefix, and are named the same as their respective file, except for mconfig and qconfig. This commit adds an alias for mconfig to menuconfig and qconfig to xconfig. Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com> --- scripts/kconfig/Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)