[v9,6/7] sign-file: use const with a global string constant

Message ID	20230809172211.343677-7-yesshedi@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-kbuild-owner@vger.kernel.org> From: Shreenidhi Shedi <yesshedi@gmail.com> To: dhowells@redhat.com, dwmw2@infradead.org, gregkh@linuxfoundation.org, masahiroy@kernel.org, nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu Cc: yesshedi@gmail.com, linux-kernel@vger.kernel.org, sshedi@vmware.com, linux-kbuild@vger.kernel.org Subject: [PATCH v9 6/7] sign-file: use const with a global string constant Date: Wed, 9 Aug 2023 22:52:09 +0530 Message-ID: <20230809172211.343677-7-yesshedi@gmail.com> In-Reply-To: <20230809172211.343677-1-yesshedi@gmail.com> References: <20230809172211.343677-1-yesshedi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	refactor file signing program \| expand [v9,0/7] refactor file signing program [v9,1/7] sign-file: use getopt_long_only for parsing input args [v9,2/7] sign-file: inntroduce few new flags to make argument processing easy. [v9,3/7] sign-file: move file signing logic to its own function [v9,4/7] sign-file: add support to sign modules in bulk [v9,5/7] sign-file: improve help message [v9,6/7] sign-file: use const with a global string constant [v9,7/7] sign-file: fix do while styling issue

Message ID

20230809172211.343677-7-yesshedi@gmail.com (mailing list archive)

State

New, archived

Headers

From: Shreenidhi Shedi <yesshedi@gmail.com>
To: dhowells@redhat.com, dwmw2@infradead.org,
        gregkh@linuxfoundation.org, masahiroy@kernel.org,
        nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu
Cc: yesshedi@gmail.com, linux-kernel@vger.kernel.org,
        sshedi@vmware.com, linux-kbuild@vger.kernel.org
Subject: [PATCH v9 6/7] sign-file: use const with a global string constant
Date: Wed,  9 Aug 2023 22:52:09 +0530
Message-ID: <20230809172211.343677-7-yesshedi@gmail.com>
In-Reply-To: <20230809172211.343677-1-yesshedi@gmail.com>
References: <20230809172211.343677-1-yesshedi@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

refactor file signing program | expand

Commit Message

Shreenidhi Shedi Aug. 9, 2023, 5:22 p.m. UTC

Reported by checkpatch.

Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
---
 scripts/sign-file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/sign-file.c b/scripts/sign-file.c
index d3abc5721a7e..e8dfbdd3eea3 100644
--- a/scripts/sign-file.c
+++ b/scripts/sign-file.c
@@ -71,7 +71,7 @@  struct module_signature {
 
 #define PKEY_ID_PKCS7 2
 
-static char magic_number[] = "~Module signature appended~\n";
+static const char magic_number[] = "~Module signature appended~\n";
 
 static __attribute__((noreturn))
 void print_usage(void)

[v9,6/7] sign-file: use const with a global string constant

Commit Message

Patch