diff mbox series

kbuild: avoid long argument lists in make modules_install

Message ID 20230911080129.38BA12016B@lion.mk-sys.cz (mailing list archive)
State New, archived
Headers show
Series kbuild: avoid long argument lists in make modules_install | expand

Commit Message

Michal Kubecek Sept. 11, 2023, 8:01 a.m. UTC 
Running "make modules_install" may fail with

  make[2]: execvp: /bin/sh: Argument list too long

if many modules are built and INSTALL_MOD_PATH is long. This is because
scripts/Makefile.modinst creates all directories with one mkdir command.
Use $(foreach ...) instead to prevent an excessive argument list.

Fixes: 2dfec887c0fd ("kbuild: reduce the number of mkdir calls during modules_install")
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
---
 scripts/Makefile.modinst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Masahiro Yamada Sept. 14, 2023, 5:37 p.m. UTC | #1 
On Mon, Sep 11, 2023 at 5:01 PM Michal Kubecek <mkubecek@suse.cz> wrote:
>
> Running "make modules_install" may fail with
>
>   make[2]: execvp: /bin/sh: Argument list too long
>
> if many modules are built and INSTALL_MOD_PATH is long. This is because
> scripts/Makefile.modinst creates all directories with one mkdir command.
> Use $(foreach ...) instead to prevent an excessive argument list.
>
> Fixes: 2dfec887c0fd ("kbuild: reduce the number of mkdir calls during modules_install")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> ---

Applied to linux-kbuild/fixes.
Thanks.



>  scripts/Makefile.modinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> index c59cc57286ba..346f5ec50682 100644
> --- a/scripts/Makefile.modinst
> +++ b/scripts/Makefile.modinst
> @@ -113,7 +113,7 @@ quiet_cmd_sign :=
>  endif
>
>  # Create necessary directories
> -$(shell mkdir -p $(sort $(dir $(install-y))))
> +$(foreach dir, $(sort $(dir $(install-y))), $(shell mkdir -p $(dir)))
>
>  $(dst)/%.ko: $(extmod_prefix)%.ko FORCE
>         $(call cmd,install)
> --
> 2.42.0
>
diff mbox series

Patch

diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
index c59cc57286ba..346f5ec50682 100644
--- a/scripts/Makefile.modinst
+++ b/scripts/Makefile.modinst
@@ -113,7 +113,7 @@  quiet_cmd_sign :=
 endif
 
 # Create necessary directories
-$(shell mkdir -p $(sort $(dir $(install-y))))
+$(foreach dir, $(sort $(dir $(install-y))), $(shell mkdir -p $(dir)))
 
 $(dst)/%.ko: $(extmod_prefix)%.ko FORCE
 	$(call cmd,install)