[1/3] kbuild: Correct missing architecture-specific hyphens

Commit Message

Simon Glass Oct. 26, 2023, 7:26 a.m. UTC

These should add a hyphen to indicate that it makes a adjective. Fix
them.

Signed-off-by: Simon Glass <[e-mail]>
---

 Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Masahiro Yamada Oct. 28, 2023, 9:50 a.m. UTC | #1

On Thu, Oct 26, 2023 at 4:27 PM Simon Glass <[e-mail]> wrote:
>
> These should add a hyphen to indicate that it makes a adjective. Fix
> them.
>
> Signed-off-by: Simon Glass <[e-mail]>
> ---


This is trivial.
Applied to linux-kbuild. Thanks.


git grep -i 'arch specific'

 or

git grep -i 'architecture specific'

finds similar patterns, but presumably we are not
keen on fixing them tree-wide.

Randy Dunlap Oct. 28, 2023, 4 p.m. UTC | #2

On 10/28/23 02:50, Masahiro Yamada wrote:
> On Thu, Oct 26, 2023 at 4:27 PM Simon Glass <[e-mail]> wrote:
>>
>> These should add a hyphen to indicate that it makes a adjective. Fix
>> them.
>>
>> Signed-off-by: Simon Glass <[e-mail]>
>> ---
> 
> 
> This is trivial.
> Applied to linux-kbuild. Thanks.
> 
> 
> git grep -i 'arch specific'
> 
>  or
> 
> git grep -i 'architecture specific'
> 
> finds similar patterns, but presumably we are not
> keen on fixing them tree-wide.

or '32 bit', '64 bit', but I agree with "not keen on
fixing them tree-wide."

Patch

diff --git a/Makefile b/Makefile
index 690cde550acd..b63796e6f94a 100644
--- a/Makefile
+++ b/Makefile
@@ -675,7 +675,7 @@  ifdef config-build
 # *config targets only - make sure prerequisites are updated, and descend
 # in scripts/kconfig to make the *config target
 
-# Read arch specific Makefile to set KBUILD_DEFCONFIG as needed.
+# Read arch-specific Makefile to set KBUILD_DEFCONFIG as needed.
 # KBUILD_DEFCONFIG may point out an alternative default configuration
 # used for 'make defconfig'
 include $(srctree)/arch/$(SRCARCH)/Makefile
@@ -689,7 +689,7 @@  config: outputmakefile scripts_basic FORCE
 
 else #!config-build
 # ===========================================================================
-# Build targets only - this includes vmlinux, arch specific targets, clean
+# Build targets only - this includes vmlinux, arch-specific targets, clean
 # targets and others. In general all targets except *config targets.
 
 # If building an external module we do not care about the all: rule
@@ -1637,9 +1637,9 @@  help:
 	@echo  'Documentation targets:'
 	@$(MAKE) -f $(srctree)/Documentation/Makefile dochelp
 	@echo  ''
-	@echo  'Architecture specific targets ($(SRCARCH)):'
+	@echo  'Architecture-specific targets ($(SRCARCH)):'
 	@$(or $(archhelp),\
-		echo '  No architecture specific help defined for $(SRCARCH)')
+		echo '  No architecture-specific help defined for $(SRCARCH)')
 	@echo  ''
 	@$(if $(boards), \
 		$(foreach b, $(boards), \
@@ -1681,7 +1681,7 @@  help-boards: $(help-board-dirs)
 boards-per-dir = $(sort $(notdir $(wildcard $(srctree)/arch/$(SRCARCH)/configs/$*/*_defconfig)))
 
 $(help-board-dirs): help-%:
-	@echo  'Architecture specific targets ($(SRCARCH) $*):'
+	@echo  'Architecture-specific targets ($(SRCARCH) $*):'
 	@$(if $(boards-per-dir), \
 		$(foreach b, $(boards-per-dir), \
 		printf "  %-24s - Build for %s\\n" $*/$(b) $(subst _defconfig,,$(b));) \