| Message ID | 20231121115855.111358-1-pvorel@suse.cz (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] kbuild: builddeb: Remove unused $dirs | expand |
Hi, I could have added some description, e.g. "shell variable $dirs is not used any more since 1fc9095846cc, therefore remove it". Please let me know if I should resent it as v2. Kind regards, Petr > Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package") > Signed-off-by: Petr Vorel <pvorel@suse.cz> > --- > scripts/package/buildtar | 2 -- > 1 file changed, 2 deletions(-) > diff --git a/scripts/package/buildtar b/scripts/package/buildtar > index 65b4ea502962..8ac075dd0e9c 100755 > --- a/scripts/package/buildtar > +++ b/scripts/package/buildtar > @@ -23,7 +23,6 @@ tmpdir=$1 > rm -rf -- "${tmpdir}" > mkdir -p -- "${tmpdir}/boot" > -dirs=boot > @@ -42,7 +41,6 @@ fi > if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then > make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install > - dirs="$dirs lib" > fi
On Tue, Nov 21, 2023 at 10:37 PM Petr Vorel <pvorel@suse.cz> wrote: > > Hi, > > I could have added some description, e.g. "shell variable $dirs is not used any > more since 1fc9095846cc, therefore remove it". > > Please let me know if I should resent it as v2. > > Kind regards, > Petr > > > Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package") > > Signed-off-by: Petr Vorel <pvorel@suse.cz> I filled the commit log and fixed the commit subject "kbuild: builddeb:" to "kbuild: buildtar:". Author: Petr Vorel <pvorel@suse.cz> Date: Tue Nov 21 12:58:54 2023 +0100 kbuild: buildtar: Remove unused $dirs The shell variable $dirs is not used any more since 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package"), therefore remove it". Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package") Signed-off-by: Petr Vorel <pvorel@suse.cz> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Thanks. > > --- > > scripts/package/buildtar | 2 -- > > 1 file changed, 2 deletions(-) > > > diff --git a/scripts/package/buildtar b/scripts/package/buildtar > > index 65b4ea502962..8ac075dd0e9c 100755 > > --- a/scripts/package/buildtar > > +++ b/scripts/package/buildtar > > @@ -23,7 +23,6 @@ tmpdir=$1 > > > rm -rf -- "${tmpdir}" > > mkdir -p -- "${tmpdir}/boot" > > -dirs=boot > > > > > @@ -42,7 +41,6 @@ fi > > > if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then > > make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install > > - dirs="$dirs lib" > > fi
Hi Masahiro, > On Tue, Nov 21, 2023 at 10:37 PM Petr Vorel <pvorel@suse.cz> wrote: > > Hi, > > I could have added some description, e.g. "shell variable $dirs is not used any > > more since 1fc9095846cc, therefore remove it". > > Please let me know if I should resent it as v2. > > Kind regards, > > Petr > > > Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package") > > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > I filled the commit log and fixed the commit subject > "kbuild: builddeb:" to "kbuild: buildtar:". Thanks for fixing this! Kind regards, Petr > Author: Petr Vorel <pvorel@suse.cz> > Date: Tue Nov 21 12:58:54 2023 +0100 > kbuild: buildtar: Remove unused $dirs > The shell variable $dirs is not used any more since 1fc9095846cc > ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package"), > therefore remove it". > Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in > scripts/Makefile.package") > Signed-off-by: Petr Vorel <pvorel@suse.cz> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > Thanks. > > > --- > > > scripts/package/buildtar | 2 -- > > > 1 file changed, 2 deletions(-) > > > diff --git a/scripts/package/buildtar b/scripts/package/buildtar > > > index 65b4ea502962..8ac075dd0e9c 100755 > > > --- a/scripts/package/buildtar > > > +++ b/scripts/package/buildtar > > > @@ -23,7 +23,6 @@ tmpdir=$1 > > > rm -rf -- "${tmpdir}" > > > mkdir -p -- "${tmpdir}/boot" > > > -dirs=boot > > > @@ -42,7 +41,6 @@ fi > > > if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then > > > make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install > > > - dirs="$dirs lib" > > > fi
diff --git a/scripts/package/buildtar b/scripts/package/buildtar index 65b4ea502962..8ac075dd0e9c 100755 --- a/scripts/package/buildtar +++ b/scripts/package/buildtar @@ -23,7 +23,6 @@ tmpdir=$1 # rm -rf -- "${tmpdir}" mkdir -p -- "${tmpdir}/boot" -dirs=boot # @@ -42,7 +41,6 @@ fi # if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install - dirs="$dirs lib" fi
Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package") Signed-off-by: Petr Vorel <pvorel@suse.cz> --- scripts/package/buildtar | 2 -- 1 file changed, 2 deletions(-)