| Message ID | 20240214012439.879134-2-andrewjballance@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | gen_compile_commands: fix invalid escape sequence warning | expand |
Hi, On Tue, Feb 13, 2024 at 07:23:05PM -0600, Andrew Ballance wrote: > with python 3.12.1 '\#' results in this warning > SyntaxWarning: invalid escape sequence '\#' > > Signed-off-by: Andrew Ballance <andrewjballance@gmail.com> You probably don't need to send a patch series (with a cover letter) if you're only sending a single patch to the list. Really, though, who cares! Reviewed-by: Justin Stitt <justinstitt@google.com> > --- > scripts/clang-tools/gen_compile_commands.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py > index 5dea4479240b..e4fb686dfaa9 100755 > --- a/scripts/clang-tools/gen_compile_commands.py > +++ b/scripts/clang-tools/gen_compile_commands.py > @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path): > # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the > # kernel version). The compile_commands.json file is not interepreted > # by Make, so this code replaces the escaped version with '#'. > - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#') > + prefix = command_prefix.replace(r'\#', '#').replace('$(pound)', '#') > > # Return the canonical path, eliminating any symbolic links encountered in the path. > abs_path = os.path.realpath(os.path.join(root_directory, file_path)) > -- > 2.43.0 > Thanks Justin
On Wed, Feb 14, 2024 at 10:25 AM Andrew Ballance <andrewjballance@gmail.com> wrote: > > with python 3.12.1 '\#' results in this warning > SyntaxWarning: invalid escape sequence '\#' I changed "3.12.1" to "3.12" when I applied it because this occurs for Python 3.12.0 Thanks. > > Signed-off-by: Andrew Ballance <andrewjballance@gmail.com> > --- > scripts/clang-tools/gen_compile_commands.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py > index 5dea4479240b..e4fb686dfaa9 100755 > --- a/scripts/clang-tools/gen_compile_commands.py > +++ b/scripts/clang-tools/gen_compile_commands.py > @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path): > # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the > # kernel version). The compile_commands.json file is not interepreted > # by Make, so this code replaces the escaped version with '#'. > - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#') > + prefix = command_prefix.replace(r'\#', '#').replace('$(pound)', '#') > > # Return the canonical path, eliminating any symbolic links encountered in the path. > abs_path = os.path.realpath(os.path.join(root_directory, file_path)) > -- > 2.43.0 >
diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py index 5dea4479240b..e4fb686dfaa9 100755 --- a/scripts/clang-tools/gen_compile_commands.py +++ b/scripts/clang-tools/gen_compile_commands.py @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path): # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the # kernel version). The compile_commands.json file is not interepreted # by Make, so this code replaces the escaped version with '#'. - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#') + prefix = command_prefix.replace(r'\#', '#').replace('$(pound)', '#') # Return the canonical path, eliminating any symbolic links encountered in the path. abs_path = os.path.realpath(os.path.join(root_directory, file_path))
with python 3.12.1 '\#' results in this warning SyntaxWarning: invalid escape sequence '\#' Signed-off-by: Andrew Ballance <andrewjballance@gmail.com> --- scripts/clang-tools/gen_compile_commands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)