| Message ID | 20240724125904.15601-1-jgross@suse.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | kbuild: Fix broken "make binrpm-pkg" | expand |
On Wed, Jul 24, 2024 at 2:59 PM Juergen Gross <jgross@suse.com> wrote: > > Due to a typo "make binrpm-pkg" isn't working when using e.g. german > locale. rpmbuild will tell me: > > error: bad date in %changelog: Mi Jul 24 2024 Juergen Gross <jgross@suse.com> > > Reason is that setting "LC_ALL=C" must not be followed by a semicolon > in order to affect the following "date" command. > > Fixes: 301c10908e42 ("kbuild: rpm-pkg: introduce a simple changelog section for kernel.spec") > Signed-off-by: Juergen Gross <jgross@suse.com> > --- > scripts/package/mkspec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/package/mkspec b/scripts/package/mkspec > index ead54d67a024..4dc1466dfc81 100755 > --- a/scripts/package/mkspec > +++ b/scripts/package/mkspec > @@ -50,6 +50,6 @@ fi > cat << EOF > > %changelog > -* $(LC_ALL=C; date +'%a %b %d %Y') ${name} <${email}> > +* $(LC_ALL=C date +'%a %b %d %Y') ${name} <${email}> > - Custom built Linux kernel. > EOF > -- > 2.43.0 > > Fixed in kbuild.git#fixes https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/log/?h=fixes https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=fixes&id=ba6c664081afd18da86ac49cb22ceb266f89a561 -Sedat-
diff --git a/scripts/package/mkspec b/scripts/package/mkspec index ead54d67a024..4dc1466dfc81 100755 --- a/scripts/package/mkspec +++ b/scripts/package/mkspec @@ -50,6 +50,6 @@ fi cat << EOF %changelog -* $(LC_ALL=C; date +'%a %b %d %Y') ${name} <${email}> +* $(LC_ALL=C date +'%a %b %d %Y') ${name} <${email}> - Custom built Linux kernel. EOF
Due to a typo "make binrpm-pkg" isn't working when using e.g. german locale. rpmbuild will tell me: error: bad date in %changelog: Mi Jul 24 2024 Juergen Gross <jgross@suse.com> Reason is that setting "LC_ALL=C" must not be followed by a semicolon in order to affect the following "date" command. Fixes: 301c10908e42 ("kbuild: rpm-pkg: introduce a simple changelog section for kernel.spec") Signed-off-by: Juergen Gross <jgross@suse.com> --- scripts/package/mkspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)