| Message ID | 20240806233559.246705-1-ojeda@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | kbuild: rust-analyzer: mark `rust_is_available.sh` invocation as recursive | expand |
On Wed, Aug 7, 2024 at 1:36 AM Miguel Ojeda <ojeda@kernel.org> wrote: > > Otherwise, we get a warning from `rustc`. Thus fix it. To be clear, this happens (only) when calling `make` with parallel jobs, e.g. `-j8`. Which does not really matter for that target, but nevertheless, some of us call `make` with jobs enabled most of the time. Cheers, Miguel
On Wed, Aug 7, 2024 at 1:36 AM Miguel Ojeda <ojeda@kernel.org> wrote: > > When calling the `rust_is_available.sh` script, we need to make the > jobserver available to it, as commit ecab4115c44c ("kbuild: mark `rustc` > (and others) invocations as recursive") explains and did for the others. > > Otherwise, we get a warning from `rustc`. Thus fix it. > > Fixes: 6dc9d9ca9a72 ("kbuild: rust-analyzer: better error handling") > Signed-off-by: Miguel Ojeda <ojeda@kernel.org> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
On Wed, Aug 7, 2024 at 1:36 AM Miguel Ojeda <ojeda@kernel.org> wrote: > > When calling the `rust_is_available.sh` script, we need to make the > jobserver available to it, as commit ecab4115c44c ("kbuild: mark `rustc` > (and others) invocations as recursive") explains and did for the others. > > Otherwise, we get a warning from `rustc`. Thus fix it. > > Fixes: 6dc9d9ca9a72 ("kbuild: rust-analyzer: better error handling") > Signed-off-by: Miguel Ojeda <ojeda@kernel.org> Applied to `rust-fixes` -- thanks everyone! [ Reworded to add a couple more details mentioned in the list. - Miguel ] Cheers, Miguel
diff --git a/Makefile b/Makefile index 44c02a6f60a1..9a33b6063a30 100644 --- a/Makefile +++ b/Makefile @@ -1963,7 +1963,7 @@ tags TAGS cscope gtags: FORCE # Protocol). PHONY += rust-analyzer rust-analyzer: - $(Q)$(CONFIG_SHELL) $(srctree)/scripts/rust_is_available.sh + +$(Q)$(CONFIG_SHELL) $(srctree)/scripts/rust_is_available.sh $(Q)$(MAKE) $(build)=rust $@ # Script to generate missing namespace dependencies
When calling the `rust_is_available.sh` script, we need to make the jobserver available to it, as commit ecab4115c44c ("kbuild: mark `rustc` (and others) invocations as recursive") explains and did for the others. Otherwise, we get a warning from `rustc`. Thus fix it. Fixes: 6dc9d9ca9a72 ("kbuild: rust-analyzer: better error handling") Signed-off-by: Miguel Ojeda <ojeda@kernel.org> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: de9c2c66ad8e787abec7c9d7eff4f8c3cdd28aed