| Message ID | 20240911110401.598586-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] btf: remove redundant CONFIG_BPF test in scripts/link-vmlinux.sh | expand |
On Wed, Sep 11, 2024 at 08:03:56PM +0900, Masahiro Yamada wrote: > CONFIG_DEBUG_INFO_BTF depends on CONFIG_BPF_SYSCALL, which in turn > selects CONFIG_BPF. > > When CONFIG_DEBUG_INFO_BTF=y, CONFIG_BPF=y is always met. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > > scripts/link-vmlinux.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > index bd196944e350..cfffc41e20ed 100755 > --- a/scripts/link-vmlinux.sh > +++ b/scripts/link-vmlinux.sh > @@ -288,7 +288,7 @@ strip_debug= > vmlinux_link vmlinux > > # fill in BTF IDs > -if is_enabled CONFIG_DEBUG_INFO_BTF && is_enabled CONFIG_BPF; then > +if is_enabled CONFIG_DEBUG_INFO_BTF; then > info BTFIDS vmlinux > ${RESOLVE_BTFIDS} vmlinux > fi > -- > 2.43.0 >
On Wed, Sep 11, 2024 at 4:04 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > CONFIG_DEBUG_INFO_BTF depends on CONFIG_BPF_SYSCALL, which in turn > selects CONFIG_BPF. > > When CONFIG_DEBUG_INFO_BTF=y, CONFIG_BPF=y is always met. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > scripts/link-vmlinux.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > LGTM Acked-by: Andrii Nakryiko <andrii@kernel.org> > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > index bd196944e350..cfffc41e20ed 100755 > --- a/scripts/link-vmlinux.sh > +++ b/scripts/link-vmlinux.sh > @@ -288,7 +288,7 @@ strip_debug= > vmlinux_link vmlinux > > # fill in BTF IDs > -if is_enabled CONFIG_DEBUG_INFO_BTF && is_enabled CONFIG_BPF; then > +if is_enabled CONFIG_DEBUG_INFO_BTF; then > info BTFIDS vmlinux > ${RESOLVE_BTFIDS} vmlinux > fi > -- > 2.43.0 >
diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh index bd196944e350..cfffc41e20ed 100755 --- a/scripts/link-vmlinux.sh +++ b/scripts/link-vmlinux.sh @@ -288,7 +288,7 @@ strip_debug= vmlinux_link vmlinux # fill in BTF IDs -if is_enabled CONFIG_DEBUG_INFO_BTF && is_enabled CONFIG_BPF; then +if is_enabled CONFIG_DEBUG_INFO_BTF; then info BTFIDS vmlinux ${RESOLVE_BTFIDS} vmlinux fi
CONFIG_DEBUG_INFO_BTF depends on CONFIG_BPF_SYSCALL, which in turn selects CONFIG_BPF. When CONFIG_DEBUG_INFO_BTF=y, CONFIG_BPF=y is always met. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- scripts/link-vmlinux.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)