| Message ID | 20240913171205.22126-2-david.hunter.linux@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/7] linux-kbuild: fix: config option can be bool | expand |
"linux-kbuild: fix:" is not an appropriate subject prefix. Just try "git log scripts/kconfig/streamline_config.pl". You will see "streamline_config.pl:" is consistently used for the commit subject. For example, "streamline_config.pl: check prompt for bool options" On Sat, Sep 14, 2024 at 2:12 AM David Hunter <david.hunter.linux@gmail.com> wrote: > > Select configs that do not have a prompt. Config options can be bool or > tristate. Ensure that bool options are also selected. I do not see an immediate benefit from this patch. Boolean CONFIG options are skipped due to the following code: if (defined($orig_configs{$config}) && $orig_configs{$config} ne "m") { next forloop; } So, I do not understand why this patch is necessary until I see 7/7. > > Signed-off-by: David Hunter <david.hunter.linux@gmail.com> > --- > scripts/kconfig/streamline_config.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl > index d51cd7ac15d2..a828d7ab7e26 100755 > --- a/scripts/kconfig/streamline_config.pl > +++ b/scripts/kconfig/streamline_config.pl > @@ -238,7 +238,7 @@ sub read_kconfig { > } > > # configs without prompts must be selected > - } elsif ($state ne "NONE" && /^\s*(tristate\s+\S|prompt\b)/) { > + } elsif ($state ne "NONE" && /^\s*((bool|tristate)\s+\S|prompt\b)/) { > # note if the config has a prompt > $prompts{$config} = 1; > -- Best Regards Masahiro Yamada
On 9/23/24 22:55, Masahiro Yamada wrote: > > I do not see an immediate benefit from this patch. > > > > Boolean CONFIG options are skipped due to the following code: > > if (defined($orig_configs{$config}) && $orig_configs{$config} ne "m") { > next forloop; > } > > > So, I do not understand why this patch is necessary > until I see 7/7. > Thank you for the feedback. I have been working on the second version for all of the patches, and I will resend the series patch soon. In the meantime, I have a few things I need cleared up, so I will reply to each email where appropriate. For this email, I was a bit unsure of what my takeaway should be from this message. Are you saying one of the following: 1) The patch should be resent, but resent after the patch that is currently 7/7 2) The patch should be combined with the patch that is currently 7/7 3) The patch message should be improved so that people can see the need for the patch As of now, my version 2 will be made with option 1, the patch will be after the current 7/7. If you had something different in mind, let me know. I would be happy to change it as needed. Thanks, David Hunter
version 2: https://lore.kernel.org/all/20241014141345.5680-8-david.hunter.linux@gmail.com/
diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl index d51cd7ac15d2..a828d7ab7e26 100755 --- a/scripts/kconfig/streamline_config.pl +++ b/scripts/kconfig/streamline_config.pl @@ -238,7 +238,7 @@ sub read_kconfig { } # configs without prompts must be selected - } elsif ($state ne "NONE" && /^\s*(tristate\s+\S|prompt\b)/) { + } elsif ($state ne "NONE" && /^\s*((bool|tristate)\s+\S|prompt\b)/) { # note if the config has a prompt $prompts{$config} = 1;
Select configs that do not have a prompt. Config options can be bool or tristate. Ensure that bool options are also selected. Signed-off-by: David Hunter <david.hunter.linux@gmail.com> --- scripts/kconfig/streamline_config.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)