From patchwork Fri Sep 13 18:06:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 13803914 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B99DB446AF; Fri, 13 Sep 2024 18:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726250788; cv=none; b=BXc3lMI+meO451bz7Tgzw/TQTM50fhHjIKUIdB3bi1ZzBzbIp2fnJHkM5glo7XHVq37eO+lrI5O6sa/Xs46dre/jAfswzAY4Ew8sK6/nDB+xMrDr7ohjFurX2EIYfzAXvTckCajPe7EpMw2sYlDa53U9Csr8AcwNADIjdiKQSQ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726250788; c=relaxed/simple; bh=2jSUwK3ok+ItiZnWlopILuxmtn6sSOQCXeuyuT4Nx1A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dnxXYHUvD12nEp0mgUH1RWRv2LsBx+wf+Hc20PzHVrUd4+poMyIVVmpb/9jSh4GWfITtpGM19lIACIyDM9l/krSF5CKJqnrIiyE0S1Dh8ZC7/HqK/qgqa/Y2i2G74Jc/e+ti6XpT9P2DS5ihhSfYUy3tDu5nELBW9Kx87VicLyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tj7Kua/3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tj7Kua/3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D5EFC4CEC0; Fri, 13 Sep 2024 18:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726250788; bh=2jSUwK3ok+ItiZnWlopILuxmtn6sSOQCXeuyuT4Nx1A=; h=From:To:Cc:Subject:Date:From; b=Tj7Kua/36ark1PAnazD1tCbN4lhY97h09dJ1Uo9PNkgVaDGDwQo/IX1Pfz33n0B9T 5SBnxDOMm7tpDJUZ2KbFb9kFBl4VUxvW17gNtafuHma4b1OAeiQ37xPdVNkN5piDuT B5EWamN7pFv2HsuSBeygSYP0hV1Z7K1k8bpt/vnoQkxyPCsNNCYPT/OoWRNDHTNnXL mx/H2w2BBO6/Dy4in/lfsES90QvMrUxXxtiWCiQ7ErkbgdkmrZ2ptA2GEVO1FJMUP8 wtSc0GwKTh1IuGzvgqpsF/1oZgiG5MuLh5rPrYEfaHT/DWUKbc3YdFaf88rCqbwfsI Ulo1AjeA9ZUTg== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , rust-for-linux@vger.kernel.org Cc: Finn Behrens , linux-kernel@vger.kernel.org, Masahiro Yamada , Alice Ryhl , Andreas Hindborg , Benno Lossin , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Boqun Feng , Gary Guo , Nathan Chancellor , Nicolas Schier Subject: [PATCH] kbuild: remove unnecessary export of RUST_LIB_SRC Date: Sat, 14 Sep 2024 03:06:20 +0900 Message-ID: <20240913180622.1327656-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 If RUST_LIB_SRC is defined in the top-level Makefile (via an environment variable or command line), it is already exported. The only situation where it is defined but not exported is when the top-level Makefile is wrapped by another Makefile (e.g., GNUmakefile). I cannot think of any other use cases. I know some people use this tip to define custom variables. However, even in that case, you can export it directly in the wrapper Makefile. Example GNUmakefile: export RUST_LIB_SRC = /path/to/your/sysroot/lib/rustlib/src/rust/library include Makefile Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier Reviewed-by: Alice Ryhl Acked-by: Miguel Ojeda Tested-by: Miguel Ojeda Acked-by: Fiona Behrens --- This code was added by this commit: https://github.com/Rust-for-Linux/linux/commit/3f46885dc03ed2d750085b2237078a1628323964 Please me know if I am missing something. Makefile | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Makefile b/Makefile index d57cfc6896b8..b194b7702a2e 100644 --- a/Makefile +++ b/Makefile @@ -578,10 +578,6 @@ else RUSTC_OR_CLIPPY = $(RUSTC) endif -ifdef RUST_LIB_SRC - export RUST_LIB_SRC -endif - # Allows the usage of unstable features in stable compilers. export RUSTC_BOOTSTRAP := 1