From patchwork Tue Sep 17 14:16:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 13806199 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CAE618594F; Tue, 17 Sep 2024 14:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726582658; cv=none; b=nKmTvDAn7sSrCBvtV1+BuSqGG6rbTP/SDM7t6RxDxG4i9j+hgbZqlvQWCAF9OZuIU0QknzI7dQsDEIxBjismJVa18mqzzN9YtGHyFCvDh6E8NWZHT2WQTF9chro7REJ34m/NaooTl4KHgzDIPyaQCANqWqlrtiiPIldL49fPCDg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726582658; c=relaxed/simple; bh=mEQ0ucDdLUQliMtanUxk44g5JWErCiGrOMyYhL1jU8I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=amXN8rxx+6+nJVy+M5GTDnPSaFvMP342KQnVZyLkvpTtnWO6Y3/h7hG/JsvKkWB07KOL0UP+vSYonH7rQNtedq2IL7bDkRVo6XcRUO303T0VQar7e9Xy8IuXR7r6FCns9X2vkHvsMMadkWG/ssJm9jk6FVDn6HmF4x3tTmLz0Mo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ToA62I3D; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ToA62I3D" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11942C4CECD; Tue, 17 Sep 2024 14:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726582657; bh=mEQ0ucDdLUQliMtanUxk44g5JWErCiGrOMyYhL1jU8I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ToA62I3DlVO5DsXeJCBgIqatkpRCPrEwx6J1aXJONw2xm9MUakM5NkaltIugwb7lc +KakMreO0NvbKPS0KLviMBXvUzL/j+Eh3r6O6ExQPdz5wkyNYotS73jNpm0LsQZz7I Kh2mKbev4qC4PefI7yP3yO1ulWguqONEdA3FruhDY9Ysoo/YZHZT9aixi8y6wHS/s9 ORphFAFmWYbK8P++ahlH2Er9J8GxSUIpaxtpHVZif+lcs08ypQhtl7GrXWbFu701uH rF3XWxTruIdrberKoFTa2Ivl5b9wjEoBA2D3GjobqUOZS3uV90pAAZHgGaUvnxuW3R yJlp/gb80RNAA== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Miguel Ojeda , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Nicolas Schier , Masahiro Yamada Subject: [PATCH 03/23] kbuild: doc: remove outdated description of the limitation on -I usage Date: Tue, 17 Sep 2024 23:16:31 +0900 Message-ID: <20240917141725.466514-4-masahiroy@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240917141725.466514-1-masahiroy@kernel.org> References: <20240917141725.466514-1-masahiroy@kernel.org> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Kbuild used to manipulate header search paths, enforcing the odd limitation of "no space after -I". Commit cdd750bfb1f7 ("kbuild: remove 'addtree' and 'flags' magic for header search paths") stopped doing that. This limitation no longer exists. Instead, you need to accurately specify the header search path. (In this case, $(src)/include) Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier --- Documentation/kbuild/modules.rst | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Documentation/kbuild/modules.rst b/Documentation/kbuild/modules.rst index 268ebbd2ab74..7eceb9a65e9c 100644 --- a/Documentation/kbuild/modules.rst +++ b/Documentation/kbuild/modules.rst @@ -328,13 +328,9 @@ according to the following rule: --> filename: Kbuild obj-m := 8123.o - ccflags-y := -Iinclude + ccflags-y := -I $(src)/include 8123-y := 8123_if.o 8123_pci.o 8123_bin.o - Note that in the assignment there is no space between -I and - the path. This is a limitation of kbuild: there must be no - space present. - 4.3 Several Subdirectories --------------------------