| Message ID | 20240917141725.466514-8-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | kbuild: support building external modules in a separate build directory | expand |
On Tue, Sep 17, 2024 at 11:16:35PM +0900, Masahiro Yamada wrote: > Commit 9d0441bab775 ("rust: alloc: remove our fork of the `alloc` > crate") removed the rust/alloc/ directory. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > Makefile | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Nicolas Schier <n.schier@avm.de>
On Thu, Sep 19, 2024 at 01:23:01PM +0200, Nicolas Schier wrote: > On Tue, Sep 17, 2024 at 11:16:35PM +0900, Masahiro Yamada wrote: > > Commit 9d0441bab775 ("rust: alloc: remove our fork of the `alloc` > > crate") removed the rust/alloc/ directory. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > --- > > > > Makefile | 2 -- > > 1 file changed, 2 deletions(-) > > Reviewed-by: Nicolas Schier <n.schier@avm.de> oh, there is still a comment about 'rust/alloc' in Makefile that probably wants to be removed, too.
On Thu, Sep 19, 2024 at 3:47 PM Nicolas Schier <n.schier@avm.de> wrote: > > oh, there is still a comment about 'rust/alloc' in Makefile that > probably wants to be removed, too. Indeed, good catch. Please feel free to remove it in this series, otherwise we can do it later. Either way: Acked-by: Miguel Ojeda <ojeda@kernel.org> Cheers, Miguel
diff --git a/Makefile b/Makefile index 35b8392d2bef..5b16e0605a77 100644 --- a/Makefile +++ b/Makefile @@ -1741,9 +1741,7 @@ PHONY += rustfmt rustfmtcheck # We `grep` afterwards in order to remove the directory entry itself. rustfmt: $(Q)find $(abs_srctree) -type f -name '*.rs' \ - -o -path $(abs_srctree)/rust/alloc -prune \ -o -path $(abs_objtree)/rust/test -prune \ - | grep -Fv $(abs_srctree)/rust/alloc \ | grep -Fv $(abs_objtree)/rust/test \ | grep -Fv generated \ | xargs $(RUSTFMT) $(rustfmt_flags)
Commit 9d0441bab775 ("rust: alloc: remove our fork of the `alloc` crate") removed the rust/alloc/ directory. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- Makefile | 2 -- 1 file changed, 2 deletions(-)