diff mbox series

kbuild: pacman-pkg: provide versioned linux-api-headers package

Message ID 20250103-kbuild-pacman-pkg-provides-v1-1-d568b4b9cfd5@weissschuh.net (mailing list archive)
State New
Headers show
Series kbuild: pacman-pkg: provide versioned linux-api-headers package | expand

Commit Message

Thomas Weißschuh Jan. 3, 2025, 6:20 p.m. UTC
The Arch Linux glibc package contains a versioned dependency on
"linux-api-headers". If the linux-api-headers package provided by
pacman-pkg does not specify an explicit version this dependency is not
satisfied.
Fix the dependency by providing an explicit version.

Fixes: c8578539deba ("kbuild: add script and target to generate pacman package")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 scripts/package/PKGBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf
change-id: 20250103-kbuild-pacman-pkg-provides-06b02d213e75

Best regards,

Comments

Nathan Chancellor Jan. 4, 2025, 5:05 a.m. UTC | #1
On Fri, Jan 03, 2025 at 07:20:23PM +0100, Thomas Weißschuh wrote:
> The Arch Linux glibc package contains a versioned dependency on
> "linux-api-headers". If the linux-api-headers package provided by
> pacman-pkg does not specify an explicit version this dependency is not
> satisfied.
> Fix the dependency by providing an explicit version.
> 
> Fixes: c8578539deba ("kbuild: add script and target to generate pacman package")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Makes sense based on my understanding of provides.

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  scripts/package/PKGBUILD | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
> index f83493838cf96ac9f209c6fc8f9b219705f9715b..dca706617adc76d01a09a86785815a48db15b099 100644
> --- a/scripts/package/PKGBUILD
> +++ b/scripts/package/PKGBUILD
> @@ -103,7 +103,7 @@ _package-headers() {
>  
>  _package-api-headers() {
>  	pkgdesc="Kernel headers sanitized for use in userspace"
> -	provides=(linux-api-headers)
> +	provides=(linux-api-headers="${pkgver}")
>  	conflicts=(linux-api-headers)
>  
>  	_prologue
> 
> ---
> base-commit: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf
> change-id: 20250103-kbuild-pacman-pkg-provides-06b02d213e75
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@weissschuh.net>
>
Masahiro Yamada Jan. 5, 2025, 2:21 p.m. UTC | #2
On Sat, Jan 4, 2025 at 3:20 AM Thomas Weißschuh <linux@weissschuh.net> wrote:
>
> The Arch Linux glibc package contains a versioned dependency on
> "linux-api-headers". If the linux-api-headers package provided by
> pacman-pkg does not specify an explicit version this dependency is not
> satisfied.
> Fix the dependency by providing an explicit version.
>
> Fixes: c8578539deba ("kbuild: add script and target to generate pacman package")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---

Applied to linux-kbuild.
Thanks!
diff mbox series

Patch

diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
index f83493838cf96ac9f209c6fc8f9b219705f9715b..dca706617adc76d01a09a86785815a48db15b099 100644
--- a/scripts/package/PKGBUILD
+++ b/scripts/package/PKGBUILD
@@ -103,7 +103,7 @@  _package-headers() {
 
 _package-api-headers() {
 	pkgdesc="Kernel headers sanitized for use in userspace"
-	provides=(linux-api-headers)
+	provides=(linux-api-headers="${pkgver}")
 	conflicts=(linux-api-headers)
 
 	_prologue