From patchwork Tue Feb 4 12:02:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Hindborg X-Patchwork-Id: 13959037 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3499920D4FC; Tue, 4 Feb 2025 12:04:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738670689; cv=none; b=FZFsqZKZOi+zuY0COWsX7F7OC1QLj8JQ09Do+XmYwTuB/7kJPsxgHEXbA3SiGUUWq/IzLUz90TqDP86FSPD0Dsdyd5SheB3AKDxtvumTScdCgkC4oYUsZX6UIUSDBgnWGHYKFDIE/cbuEpTRW5523NCqOCSUbUXG+hNxbkYmiqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738670689; c=relaxed/simple; bh=9vPDXVCZikkxMhidQOZWaazwuq2iUI09NMwF0gUW9wg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C2599r7yKr1a7PFIW6BplcNGf650hNrUFc0XVUYVF+VWkKZtpshmpIoHocxjfSSFWkhYsKVv0O+aQNjsuEplr63z/umTlO1FeLbxwtAT91T3gIz/lUOH5naZeLv4TMMbNN6puRJ9jxnIegtg/iPW1L7gQUXiHvxVwo+LnSRrkjo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z6pao0g4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z6pao0g4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 310EEC4CEE2; Tue, 4 Feb 2025 12:04:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738670688; bh=9vPDXVCZikkxMhidQOZWaazwuq2iUI09NMwF0gUW9wg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Z6pao0g4daPzRa6LJBDNuC7MDm1Th2cwvfOc1o6NClkaA1oD/nkZ4dNMtNFnWguXx s9Utn79EwmG6fXmz7ZsbZYjCwOiRooCzHNYz6hSX8mWUA/KvsE2SO2WNsS3lzDH2EO TiOciZuzgbvFTLJgO/iCOlDaANnJSMjwOqy3YixP5K4i7gKmhul+86y6nEPRrY2y4h //WhYDY8USbuzbWhTRo7q6WxPWi++b4ZB+zqZuhlEi/kdOzBCB9EJWRoTbLSI8h6an pWOSFiOfcgfLXfqDxpI5vR4TiAWSbe9wrgYUQooqjrmElNUlqLqNDZwuziwmIHyT5R nCf3jveALtZqA== From: Andreas Hindborg Date: Tue, 04 Feb 2025 13:02:09 +0100 Subject: [PATCH v5 2/5] rust: str: implement `Index` for `BStr` Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250204-module-params-v3-v5-2-bf5ec2041625@kernel.org> References: <20250204-module-params-v3-v5-0-bf5ec2041625@kernel.org> In-Reply-To: <20250204-module-params-v3-v5-0-bf5ec2041625@kernel.org> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Luis Chamberlain Cc: Trevor Gross , Adam Bratschi-Kaye , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Petr Pavlu , Sami Tolvanen , Daniel Gomez , Simona Vetter , Greg KH , linux-modules@vger.kernel.org, Andreas Hindborg X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1037; i=a.hindborg@kernel.org; h=from:subject:message-id; bh=9vPDXVCZikkxMhidQOZWaazwuq2iUI09NMwF0gUW9wg=; b=owEBbQKS/ZANAwAIAeG4Gj55KGN3AcsmYgBnogHYtdTSaVz/dqlQ5RrubPDCr5mbmsMF4q4ti GgEmSdim+aJAjMEAAEIAB0WIQQSwflHVr98KhXWwBLhuBo+eShjdwUCZ6IB2AAKCRDhuBo+eShj d0y+EACFCOFREKetB1YvSS7kZ4bSlsoV4btfPADQcByqGyDyST6KsA+Zu1ECm2txVUKtLSZVt89 1Qa2nbUOSujvLJMoB9fFhYVLfZf6zX2o2KfpQopZ1i0CTi8KWeYzMk1ZQWTkCA4Q9gJmBr3uANj LL3rG3hdzdL6unTPibplFpHqEQUe6Yk1Mx7ATJQNM5xChgckhkq/Dpy+zBPRscQJZc6qQFPFYEJ Itc4wCc/b+wH+fIlVdwRSbtnaa6IY3tnGiSbfaE3qVjVT8fjLGwsZjWsqgqCe9wbKagQPhmrAP5 rHmdBDvG6ex3zqH+WUXPgvcZDyeaxP8MmO8urqS2nzGuCQ83XcNdt75xMnrZzdQsmLX1S9TBRvx IlEDKj8SlUTXlCMbGj1csu1vVk3n0opJ6zmX2h9VV9mIUIKgkp8vuBdTJrjntDisIi1RwanDc7k X3F0/dfR/tk4kN11l83BKHU1cw/9AsDHowB0SD8omHgxr/lj7KmIYXRBl2LFuNThqnn/pM9wI0+ xVInRDeiwO122+xOxFEKYKYi+3hmPQahaDY5TXS8oZki9lK/RNLNZcKgcG33JXK/KBzmEVqE396 nFaz9/7A8QIsUMCMpLoWQZ0GtxYya98ZjoPvDJ+/+0XPQa+Qj3OsTw4ou6wEMgmpciTwqC5Sy0H 6SBtY/8Uut6i9ig== X-Developer-Key: i=a.hindborg@kernel.org; a=openpgp; fpr=3108C10F46872E248D1FB221376EB100563EF7A7 The `Index` implementation on `BStr` was lost when we switched `BStr` from a type alias of `[u8]` to a newtype. This patch adds back `Index` by implementing `Index` for `BStr` when `Index` would be implemented for `[u8]`. Signed-off-by: Andreas Hindborg --- rust/kernel/str.rs | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs index 002dcddf7c7687522a0acbff3ce6f65fa890e216..1eb945bed77d6592216cf30678fcca70d4c0b3b3 100644 --- a/rust/kernel/str.rs +++ b/rust/kernel/str.rs @@ -114,6 +114,17 @@ fn eq(&self, other: &Self) -> bool { } } +impl Index for BStr +where + Idx: core::slice::SliceIndex<[u8], Output = [u8]>, +{ + type Output = Self; + + fn index(&self, index: Idx) -> &Self::Output { + BStr::from_bytes(&self.0[index]) + } +} + /// Creates a new [`BStr`] from a string literal. /// /// `b_str!` converts the supplied string literal to byte string, so non-ASCII