From patchwork Thu Aug 23 18:13:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 10574505 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F2DDC13B8 for ; Thu, 23 Aug 2018 18:14:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E1D7B2C499 for ; Thu, 23 Aug 2018 18:14:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D56272C49E; Thu, 23 Aug 2018 18:14:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17DA72C499 for ; Thu, 23 Aug 2018 18:14:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726985AbeHWVoy (ORCPT ); Thu, 23 Aug 2018 17:44:54 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:55028 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726917AbeHWVoy (ORCPT ); Thu, 23 Aug 2018 17:44:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-ID:Subject:From:Cc:To:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=H8yrnYW3IXgnmy0c5LJcQAxczCJoIO7+FQgJh0VZRlM=; b=IQWL65TVXHC3AMO96xiFqSsHh z6IUD5LZNZV0ra0ProqWNLvGbqZh+baVW0Wya7vpY1tvJUBwRNpmVq1jzB5hIE8qaOkniGsGODlw2 jHA+AIKVHb/RHMkxSsQThE+QbKxFotChJVCXHcaJEu+5jUB6IatO12zS0VmtSzGdn2mqBHu7RAFPJ KkunfGA3HFHVsL++HWqAR/mRe9aHaS3wfMW/lS2/jDk5tbGAJCdb0rz6sJ4meEQV1VyC3laPgkGjR fyI3X/P91OzXTa0qoCq1cFNgF1YYrrTNECmhPop0PaglWkHgGe9FJihLRp7wLacFHRs+2GSjPV5S7 CGVh1lZug==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlab) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fsu7K-00033W-51; Thu, 23 Aug 2018 18:13:58 +0000 To: linux-kbuild , LKML , Masahiro Yamada , Greg Kroah-Hartman Cc: stable , Lucas De Marchi , Lucas De Marchi , Michal Marek , Jessica Yu , Chih-Wei Huang , "H. Nikolaus Schaller" From: Randy Dunlap Subject: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error Message-ID: <4449cd91-fae5-caf1-a917-82e0c5f0aba8@infradead.org> Date: Thu, 23 Aug 2018 11:13:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Language: en-US Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status. Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package. Signed-off-by: Randy Dunlap Fixes: 934193a654c1 ("kbuild: verify that $DEPMOD is installed") Cc: stable@vger.kernel.org Cc: Lucas De Marchi Cc: Lucas De Marchi Cc: Michal Marek Cc: Jessica Yu Cc: Chih-Wei Huang Cc: H. Nikolaus Schaller Reported-by: H. Nikolaus Schaller --- v2: add missing "exit 0" and update the commit message (no Error). v3: add Fixes: and Cc: stable scripts/depmod.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- lnx-418.orig/scripts/depmod.sh +++ lnx-418/scripts/depmod.sh @@ -15,9 +15,9 @@ if ! test -r System.map ; then fi if [ -z $(command -v $DEPMOD) ]; then - echo "'make modules_install' requires $DEPMOD. Please install it." >&2 + echo "Warning: 'make modules_install' requires $DEPMOD. Please install it." >&2 echo "This is probably in the kmod package." >&2 - exit 1 + exit 0 fi # older versions of depmod require the version string to start with three