diff mbox

KBUILD EXTMOD: Don't echo test -e for autoconf.h, even in verbose mode

Message ID 51008E94.7020702@nvidia.com (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Dadap Jan. 24, 2013, 1:29 a.m. UTC 
The top-level Makefile tests to make sure autoconf.h is present before
building external modules. This test is performed silently unless
KBUILD_VERBOSE is set, in which case the test, along with the error
messages that gets printed when the test fails, shows up in `make`
output, regardless of whether the test succeeds.

Although there may be some utility in actually printing the test along
with the error message when building with KBUILD_VERBOSE, in practice,
the error message can confuse people building external modules.

Signed-off-by: Daniel Dadap <ddadap@nvidia.com>
Reviewed-by:   Andy Ritger <aritger@nvidia.com>
---
  Makefile |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 07bc925..11f1e69 100644
--- a/Makefile
+++ b/Makefile
@@ -537,7 +537,7 @@  else
  PHONY += include/config/auto.conf

  include/config/auto.conf:
-    $(Q)test -e include/generated/autoconf.h -a -e $@ || (        \
+    @test -e include/generated/autoconf.h -a -e $@ || (        \
      echo;                                \
      echo "  ERROR: Kernel configuration is invalid.";        \
      echo "         include/generated/autoconf.h or $@ are missing.";\