From patchwork Thu Jan 24 01:29:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Dadap X-Patchwork-Id: 2027531 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 17581E00CF for ; Thu, 24 Jan 2013 01:31:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753104Ab3AXBba (ORCPT ); Wed, 23 Jan 2013 20:31:30 -0500 Received: from hqemgate03.nvidia.com ([216.228.121.140]:19711 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753047Ab3AXBaj (ORCPT ); Wed, 23 Jan 2013 20:30:39 -0500 Received: from hqnvupgp05.nvidia.com (Not Verified[216.228.121.13]) by hqemgate03.nvidia.com id ; Wed, 23 Jan 2013 17:34:55 -0800 Received: from hqemhub01.nvidia.com ([172.17.108.22]) by hqnvupgp05.nvidia.com (PGP Universal service); Wed, 23 Jan 2013 17:30:38 -0800 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Wed, 23 Jan 2013 17:30:38 -0800 Received: from hqnvemgw01.nvidia.com (172.20.150.20) by hqemhub01.nvidia.com (172.20.150.30) with Microsoft SMTP Server id 8.3.297.1; Wed, 23 Jan 2013 17:30:38 -0800 Received: from [192.168.1.91] (Not Verified[172.20.40.65]) by hqnvemgw01.nvidia.com with MailMarshal (v6,7,2,8378) id ; Wed, 23 Jan 2013 17:31:39 -0800 Message-ID: <51008E94.7020702@nvidia.com> Date: Wed, 23 Jan 2013 19:29:56 -0600 From: Daniel Dadap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.10) Gecko/20121027 Icedove/10.0.10 MIME-Version: 1.0 To: Subject: [PATCH] KBUILD EXTMOD: Don't echo test -e for autoconf.h, even in verbose mode Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org The top-level Makefile tests to make sure autoconf.h is present before building external modules. This test is performed silently unless KBUILD_VERBOSE is set, in which case the test, along with the error messages that gets printed when the test fails, shows up in `make` output, regardless of whether the test succeeds. Although there may be some utility in actually printing the test along with the error message when building with KBUILD_VERBOSE, in practice, the error message can confuse people building external modules. Signed-off-by: Daniel Dadap Reviewed-by: Andy Ritger --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 07bc925..11f1e69 100644 --- a/Makefile +++ b/Makefile @@ -537,7 +537,7 @@ else PHONY += include/config/auto.conf include/config/auto.conf: - $(Q)test -e include/generated/autoconf.h -a -e $@ || ( \ + @test -e include/generated/autoconf.h -a -e $@ || ( \ echo; \ echo " ERROR: Kernel configuration is invalid."; \ echo " include/generated/autoconf.h or $@ are missing.";\