From patchwork Fri Mar 13 19:21:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Rowand X-Patchwork-Id: 6008881 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 440B0BF90F for ; Fri, 13 Mar 2015 19:21:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 53CC4201DD for ; Fri, 13 Mar 2015 19:21:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A629201ED for ; Fri, 13 Mar 2015 19:21:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754134AbbCMTVu (ORCPT ); Fri, 13 Mar 2015 15:21:50 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:32985 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943AbbCMTVt (ORCPT ); Fri, 13 Mar 2015 15:21:49 -0400 Received: by padet14 with SMTP id et14so31786174pad.0; Fri, 13 Mar 2015 12:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:reply-to:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=hynwglHnA8dUsO9LczWpAnO4Out8Cwa0q/hTkewcJDg=; b=e588fDBnnqrbxZpSPGBzpnmxhokozo8Og5LX3M4mRuHzPRjjPzG06NogF30bNEYLNh tThSLLhTiu30eeMueosYV24HcK0S4nlph4+HFl5AejAC/e7kvfU2aBsrYB8ISndMgSgO gf4HmHYPSbJFLNP8AZACPxPo5JiPZZ6TgSP0YKQGwIHKr1nNAIJKmuR5s34kdLFxkp6Y sWOEfZW989+5Gjyo+uZycHWFYuVD52CFo/QwG9yCrVqefOgunztgtXoXiX8oDd1TvAfe T5AtAKWs1ym7I6tocZZVJ0ZJj38/MjDLPR7bEiZokr6C1zr/lB7eZwptFb/iI9+KB5Ba KFSQ== X-Received: by 10.70.103.8 with SMTP id fs8mr106157966pdb.154.1426274509347; Fri, 13 Mar 2015 12:21:49 -0700 (PDT) Received: from [192.168.1.62] (c-107-3-131-153.hsd1.ca.comcast.net. [107.3.131.153]) by mx.google.com with ESMTPSA id b12sm4749776pdl.62.2015.03.13.12.21.47 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Mar 2015 12:21:48 -0700 (PDT) Message-ID: <550338CA.50003@gmail.com> Date: Fri, 13 Mar 2015 12:21:46 -0700 From: Frank Rowand Reply-To: frowand.list@gmail.com User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Grant Likely , Rob Herring , Michal Marek , Linux Kernel list , "devicetree@vger.kernel.org" , linux-kbuild@vger.kernel.org Subject: [Patch] dt: OF_UNITTEST make dependency broken Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Frank Rowand If CONFIG_OF_UNITTEST=y then a kernel image make will always cause .version to be incremented, even if there are not source changes. This is caused by a lack of dependency tracking and checking for drivers/of/unittest-data/testcases.dtb.o. Signed-off-by: Frank Rowand --- drivers/of/Makefile | 5 +++-- drivers/of/unittest-data/.gitignore | 2 ++ drivers/of/unittest-data/Makefile | 7 +++++++ 3 files changed, 12 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: b/drivers/of/Makefile =================================================================== --- a/drivers/of/Makefile +++ b/drivers/of/Makefile @@ -6,8 +6,7 @@ obj-$(CONFIG_OF_PROMTREE) += pdt.o obj-$(CONFIG_OF_ADDRESS) += address.o obj-$(CONFIG_OF_IRQ) += irq.o obj-$(CONFIG_OF_NET) += of_net.o -obj-$(CONFIG_OF_UNITTEST) += of_unittest.o -of_unittest-objs := unittest.o unittest-data/testcases.dtb.o +obj-$(CONFIG_OF_UNITTEST) += unittest.o obj-$(CONFIG_OF_MDIO) += of_mdio.o obj-$(CONFIG_OF_PCI) += of_pci.o obj-$(CONFIG_OF_PCI_IRQ) += of_pci_irq.o @@ -16,5 +15,7 @@ obj-$(CONFIG_OF_RESERVED_MEM) += of_rese obj-$(CONFIG_OF_RESOLVE) += resolver.o obj-$(CONFIG_OF_OVERLAY) += overlay.o +obj-$(CONFIG_OF_UNITTEST) += unittest-data/ + CFLAGS_fdt.o = -I$(src)/../../scripts/dtc/libfdt CFLAGS_fdt_address.o = -I$(src)/../../scripts/dtc/libfdt Index: b/drivers/of/unittest-data/Makefile =================================================================== --- /dev/null +++ b/drivers/of/unittest-data/Makefile @@ -0,0 +1,7 @@ +obj-y += testcases.dtb.o + +targets += testcases.dtb testcases.dtb.S + +.SECONDARY: \ + $(obj)/testcases.dtb.S \ + $(obj)/testcases.dtb Index: b/drivers/of/unittest-data/.gitignore =================================================================== --- /dev/null +++ b/drivers/of/unittest-data/.gitignore @@ -0,0 +1,2 @@ +testcases.dtb +testcases.dtb.S