From patchwork Fri Jul 3 11:33:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Ruprecht X-Patchwork-Id: 6714421 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F337AC05AC for ; Fri, 3 Jul 2015 11:33:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5C721207F6 for ; Fri, 3 Jul 2015 11:33:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9213C207F3 for ; Fri, 3 Jul 2015 11:33:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755031AbbGCLdz (ORCPT ); Fri, 3 Jul 2015 07:33:55 -0400 Received: from mx-rz-3.rrze.uni-erlangen.de ([131.188.11.22]:54804 "EHLO mx-rz-3.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755113AbbGCLdy (ORCPT ); Fri, 3 Jul 2015 07:33:54 -0400 Received: from boeck4.rrze.uni-erlangen.de (boeck4.rrze.uni-erlangen.de [131.188.11.34]) by mx-rz-3.rrze.uni-erlangen.de (Postfix) with ESMTP id 3mNDhJ3fT2zFMvc; Fri, 3 Jul 2015 13:33:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fau.de; s=fau-2013; t=1435923232; bh=A1MdNHldOU8GuGxdcOhPY59g+aWZuweA5W27pQGb6hA=; h=Date:From:To:CC:Subject:References:In-Reply-To:From; b=WykQf313euZ2ShaM1iHcrermXZjRIUUB+usNK/PZN+oSb3tb2SbRCseSnpbAKdXuF keI3lW4U/NBBGU8BeVpl8to6fWwQNdELJteRBOuF7Bq70+pstLIb8dcwlj+vO1eOwB 8teqq9GdgjKLB45t6hY0/QOnEZNHw78wGr4vLQRWyzm3ufV4Ie68T+Hjs5KPm/51Hm /G5d6bylVcm/uuxTDUpUshmgV0t2VjH+ra2T764fwDFFtl5WRpL7kjre6dAbEeVlWP vIkpD8afAP6jP8dFnDfQnDS5v6XQNgnmlru4g0uWg1EFu29hc8ouPNs9SHFM4f1KiQ OfUGeTLZk4Ibw== X-Virus-Scanned: amavisd-new at boeck4.rrze.uni-erlangen.de (RRZE) Received: from mx-rz-3.rrze.uni-erlangen.de ([131.188.11.22]) by boeck4.rrze.uni-erlangen.de (boeck4.rrze.uni-erlangen.de [131.188.11.34]) (amavisd-new, port 10026) with LMTP id bj7_jPb2WpqV; Fri, 3 Jul 2015 13:33:51 +0200 (CEST) Received: from mx-rz-smart.rrze.uni-erlangen.de (mx-rz-smart.rrze.uni-erlangen.de [IPv6:2001:638:a000:1025::1e]) by mx-rz-3.rrze.uni-erlangen.de (Postfix) with ESMTP id 3mNDhH5JF1zFMtB; Fri, 3 Jul 2015 13:33:51 +0200 (CEST) X-RRZE-Submit-IP: 2001:638:a000:4142::ff0f:d304 Received: from [IPv6:2001:638:a000:4142::ff0f:d304] (unknown [IPv6:2001:638:a000:4142::ff0f:d304]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: U2FsdGVkX1+a2qxpwf9KW+xd08JwkYXd96RE2FP9EoE=) by smtp-auth.uni-erlangen.de (Postfix) with ESMTPSA id 3mNDhH4y6QzHnhy; Fri, 3 Jul 2015 13:33:51 +0200 (CEST) Message-ID: <5596731F.20309@fau.de> Date: Fri, 03 Jul 2015 13:33:51 +0200 From: Andreas Ruprecht User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ulf Magnusson CC: Paul Bolle , Valentin Rothberg , rafael.j.wysocki@intel.com, linux-kbuild@vger.kernel.org, Kernel Mailing List , hengelein Stefan , linux@dominikbrodowski.net Subject: Re: Kconfig: '+config' valid syntax? References: <1435827662.2423.4.camel@tiscali.nl> <55952723.80801@fau.de> <1435839005.2423.28.camel@tiscali.nl> <55963AD7.3040905@fau.de> <1435913987.2423.38.camel@tiscali.nl> <559655E3.6010400@fau.de> In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 07/03/2015 12:46, Ulf Magnusson wrote: > > Except for scattered accidents like in the original message, which are > hopefully pretty rare and easy to fix, the only documented thing that depends > on that lexer sloppiness is the ---help--- "token". > > I'd just add "---help---" as another T_HELP alias (or get rid of it altogether, > but that's probably more work than it's worth). Tightening things up should be > safe after that. > > /Ulf > So we might want to do something like the attached patch, right? Unfortunately, when I generate the zconf.{hash,lex,tab}.c files on my machine, they have some notable differences to the _shipped versions: ruprecht@box:linux-next$ diff -u zconf.tab.c zconf.tab.c_shipped - return yyresult; + /* Make sure YYID is used. */ + return YYID (yyresult); and I can't find any Documentation on how to properly rebuild the _shipped files... Does anybody have a hint on that? Regards, Andreas diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l index 200a3fe..84a5d05 100644 --- a/scripts/kconfig/zconf.l +++ b/scripts/kconfig/zconf.l @@ -106,7 +106,15 @@ n [A-Za-z0-9_] zconflval.string = text; return T_WORD; } - . + "---help---" { + /* Support old syntax for help statement */ + return T_HELP; + } + . { + fprintf(stderr, + "%s:%d:warning: ignoring unsupported character '%c'\n", + zconf_curname(), zconf_lineno(), *yytext); + } \n { BEGIN(INITIAL); current_file->lineno++; @@ -132,7 +140,6 @@ n [A-Za-z0-9_] BEGIN(STRING); } \n BEGIN(INITIAL); current_file->lineno++; return T_EOL; - --- /* ignore */ ({n}|[-/.])+ { const struct kconf_id *id = kconf_id_lookup(yytext, yyleng); if (id && id->flags & TF_PARAM) {