| Message ID | 7f7dfd3d-6d4b-fc64-956b-1defc5c5a7c3@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2018-07-03 5:50 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>: > On 07/02/18 13:41, Randy Dunlap wrote: > >> --- linux-next-20180702.orig/init/Kconfig >> +++ linux-next-20180702/init/Kconfig >> @@ -1717,6 +1717,12 @@ config PROFILING >> config TRACEPOINTS >> bool >> >> +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig >> +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS >> +# before the default value is found in arch/Kconfig. >> + >> +source "arch/$(SRCARCH)/Kconfig" >> + >> source "arch/Kconfig" >> >> endmenu # General setup >> > > except that the endmenu should be moved up a few lines so that the > Processor type and features menu is not part of the General setup menu. > > v2 patch is below. > > --- > From: Randy Dunlap <rdunlap@infradead.org> > > Present "General setup" before "Processor type and features". > This is done by sourcing arch/$(SRCARCH)/Kconfig before arch/Kconfig > inside init/Kconfig. > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > --- > v2: move General setup's endmenu before the $ARCH Kconfigs. > > Kconfig | 2 -- > init/Kconfig | 10 ++++++++-- > 2 files changed, 8 insertions(+), 4 deletions(-) > > --- linux-next-20180702.orig/Kconfig > +++ linux-next-20180702/Kconfig > @@ -9,8 +9,6 @@ comment "Compiler: $(CC_VERSION_TEXT)" > > source "scripts/Kconfig.include" > > -source "arch/$(SRCARCH)/Kconfig" > - > source "init/Kconfig" > > source "kernel/Kconfig.freezer" > --- linux-next-20180702.orig/init/Kconfig > +++ linux-next-20180702/init/Kconfig > @@ -1717,10 +1717,16 @@ config PROFILING > config TRACEPOINTS > bool > > -source "arch/Kconfig" > - > endmenu # General setup > > +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig > +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS > +# before the default value is found in arch/Kconfig. Is it possible to explain it in a little more generic way? ... so that arch/$(SRCARCH)/Kconfig can override the default values in arch/Kconfig. I am not a native speaker. Please reword it so that it sounds more natural. Thanks. > +source "arch/$(SRCARCH)/Kconfig" > + > +source "arch/Kconfig" > + > config RT_MUTEXES > bool > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-next-20180702.orig/Kconfig +++ linux-next-20180702/Kconfig @@ -9,8 +9,6 @@ comment "Compiler: $(CC_VERSION_TEXT)" source "scripts/Kconfig.include" -source "arch/$(SRCARCH)/Kconfig" - source "init/Kconfig" source "kernel/Kconfig.freezer" --- linux-next-20180702.orig/init/Kconfig +++ linux-next-20180702/init/Kconfig @@ -1717,10 +1717,16 @@ config PROFILING config TRACEPOINTS bool -source "arch/Kconfig" - endmenu # General setup +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS +# before the default value is found in arch/Kconfig. + +source "arch/$(SRCARCH)/Kconfig" + +source "arch/Kconfig" + config RT_MUTEXES bool