diff mbox

[2/2] xconfig: fix missing suboption and help panels on first run

Message ID 83475b00-45f0-0140-d024-b946b4999087@infradead.org (mailing list archive)
State New, archived
Headers show

Commit Message

Randy Dunlap Nov. 30, 2016, 10:57 p.m. UTC 
From: Boris Barbulovski <bbarbulovski@gmail.com>

qconfig initial slider sizes fix.

On first `make xconfig`, suboption and help panels were hidden.
Now we properly detect the first run, and show those panels.

Reported-by: Jason Vas Dias <jason.vas.dias@gmail.com>
Signed-off-by: Boris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
---
 scripts/kconfig/qconf.cc |   16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

Boris asked me to push these 2 patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Michal Marek Dec. 11, 2016, 8:42 p.m. UTC | #1 
On Wed, Nov 30, 2016 at 02:57:55PM -0800, Randy Dunlap wrote:
> From: Boris Barbulovski <bbarbulovski@gmail.com>
> 
> qconfig initial slider sizes fix.
> 
> On first `make xconfig`, suboption and help panels were hidden.
> Now we properly detect the first run, and show those panels.
> 
> Reported-by: Jason Vas Dias <jason.vas.dias@gmail.com>
> Signed-off-by: Boris Barbulovski <bbarbulovski@gmail.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>

Applied to kbuild.git#kconfig.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- lnx-49-rc7.orig/scripts/kconfig/qconf.cc
+++ lnx-49-rc7/scripts/kconfig/qconf.cc
@@ -65,11 +65,19 @@  ConfigSettings::ConfigSettings()
 QList<int> ConfigSettings::readSizes(const QString& key, bool *ok)
 {
 	QList<int> result;
-	QStringList entryList = value(key).toStringList();
-	QStringList::Iterator it;
 
-	for (it = entryList.begin(); it != entryList.end(); ++it)
-		result.push_back((*it).toInt());
+	if (contains(key))
+	{
+		QStringList entryList = value(key).toStringList();
+		QStringList::Iterator it;
+
+		for (it = entryList.begin(); it != entryList.end(); ++it)
+			result.push_back((*it).toInt());
+
+		*ok = true;
+	}
+	else
+		*ok = false;
 
 	return result;
 }