| Message ID | 874li0vvii.fsf@turtle.gmx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2018-06-19 2:45 GMT+09:00 Sven Joachim <svenjoac@gmx.de>: > When building a 64-bit 4.18-rc1 kernel with a 32-bit userland, I > noticed that stack protection was silently disabled. Adding -m64 in > gcc-x86_64-has-stack-protector.sh fixed that, similar to what has been > noticed in commit 2a61f4747eea ("stack-protector: test compiler > capability in Kconfig and drop AUTO mode") for > gcc-x86_32-has-stack-protector.sh. > > Signed-off-by: Sven Joachim <svenjoac@gmx.de> > --- Applied to linux-kbuild/fixes. Thanks! > scripts/gcc-x86_64-has-stack-protector.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/gcc-x86_64-has-stack-protector.sh b/scripts/gcc-x86_64-has-stack-protector.sh > index 3755af0cd9f7..75e4e22b986a 100755 > --- a/scripts/gcc-x86_64-has-stack-protector.sh > +++ b/scripts/gcc-x86_64-has-stack-protector.sh > @@ -1,4 +1,4 @@ > #!/bin/sh > # SPDX-License-Identifier: GPL-2.0 > > -echo "int foo(void) { char X[200]; return 3; }" | $* -S -x c -c -O0 -mcmodel=kernel -fno-PIE -fstack-protector - -o - 2> /dev/null | grep -q "%gs" > +echo "int foo(void) { char X[200]; return 3; }" | $* -S -x c -c -m64 -O0 -mcmodel=kernel -fno-PIE -fstack-protector - -o - 2> /dev/null | grep -q "%gs" > -- > 2.17.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/scripts/gcc-x86_64-has-stack-protector.sh b/scripts/gcc-x86_64-has-stack-protector.sh index 3755af0cd9f7..75e4e22b986a 100755 --- a/scripts/gcc-x86_64-has-stack-protector.sh +++ b/scripts/gcc-x86_64-has-stack-protector.sh @@ -1,4 +1,4 @@ #!/bin/sh # SPDX-License-Identifier: GPL-2.0 -echo "int foo(void) { char X[200]; return 3; }" | $* -S -x c -c -O0 -mcmodel=kernel -fno-PIE -fstack-protector - -o - 2> /dev/null | grep -q "%gs" +echo "int foo(void) { char X[200]; return 3; }" | $* -S -x c -c -m64 -O0 -mcmodel=kernel -fno-PIE -fstack-protector - -o - 2> /dev/null | grep -q "%gs"
When building a 64-bit 4.18-rc1 kernel with a 32-bit userland, I noticed that stack protection was silently disabled. Adding -m64 in gcc-x86_64-has-stack-protector.sh fixed that, similar to what has been noticed in commit 2a61f4747eea ("stack-protector: test compiler capability in Kconfig and drop AUTO mode") for gcc-x86_32-has-stack-protector.sh. Signed-off-by: Sven Joachim <svenjoac@gmx.de> --- scripts/gcc-x86_64-has-stack-protector.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)